Modify the name of popover button

Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>
opensearch-project · Apr 25, 2024 · 91dbbac · 91dbbac
1 parent 0c9e147
commit 91dbbac
Show file tree

Hide file tree

Showing 8 changed files with 55 additions and 78 deletions.
diff --git a/...nents/data_source_aggregated_view/__snapshots__/data_source_aggregated_view.test.tsx.snap b/...nents/data_source_aggregated_view/__snapshots__/data_source_aggregated_view.test.tsx.snap
diff --git a/..._management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx b/..._management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx
@@ -4,15 +4,7 @@
  */
 
 import React from 'react';
-import {
-  EuiButtonEmpty,
-  EuiContextMenuPanel,
-  EuiPanel,
-  EuiPopover,
-  EuiSelectable,
-  EuiSwitch,
-} from '@elastic/eui';
-import { i18n } from '@osd/i18n';
+import { EuiContextMenuPanel, EuiPanel, EuiPopover, EuiSelectable, EuiSwitch } from '@elastic/eui';
 import {
   ApplicationStart,
   IUiSettingsClient,
@@ -34,7 +26,7 @@ import { DataSourceOption } from '../data_source_menu/types';
 import { DataSourceItem } from '../data_source_item';
 import { DataSourceDropDownHeader } from '../drop_down_header';
 import './data_source_aggregated_view.scss';
-import { PopoverButton } from '../popover_button/popover_button';
+import { DataSourceMenuPopoverButton } from '../popover_button/popover_button';
 
 interface DataSourceAggregatedViewProps {
   savedObjectsClient: SavedObjectsClientContract;
@@ -205,7 +197,7 @@ export class DataSourceAggregatedView extends React.Component<
         <EuiPopover
           id={'dataSourceSViewContextMenuPopover'}
           button={
-            <PopoverButton
+            <DataSourceMenuPopoverButton
               className={'dataSourceAggregatedView'}
               onClick={this.onDataSourcesClick.bind(this)}
             />

diff --git a/...blic/components/data_source_selectable/__snapshots__/data_source_selectable.test.tsx.snap b/...blic/components/data_source_selectable/__snapshots__/data_source_selectable.test.tsx.snap
diff --git a/...ata_source_management/public/components/data_source_selectable/data_source_selectable.tsx b/...ata_source_management/public/components/data_source_selectable/data_source_selectable.tsx
@@ -9,7 +9,6 @@ import {
   EuiPopover,
   EuiContextMenuPanel,
   EuiPanel,
-  EuiButtonEmpty,
   EuiSelectable,
   EuiPopoverTitle,
 } from '@elastic/eui';
@@ -37,7 +36,7 @@ import './data_source_selectable.scss';
 import { DataSourceDropDownHeader } from '../drop_down_header';
 import '../button_title.scss';
 import './data_source_selectable.scss';
-import { PopoverButton } from '../popover_button/popover_button';
+import { DataSourceMenuPopoverButton } from '../popover_button/popover_button';
 
 interface DataSourceSelectableProps {
   savedObjectsClient: SavedObjectsClientContract;
@@ -261,7 +260,7 @@ export class DataSourceSelectable extends React.Component<
         initialFocus={'.euiSelectableSearch'}
         id={'dataSourceSelectableContextMenuPopover'}
         button={
-          <PopoverButton
+          <DataSourceMenuPopoverButton
             className={'dataSourceSelectable'}
             label={label}
             onClick={this.onClick.bind(this)}

diff --git a/...anagement/public/components/data_source_view/__snapshots__/data_source_view.test.tsx.snap b/...anagement/public/components/data_source_view/__snapshots__/data_source_view.test.tsx.snap
diff --git a/src/plugins/data_source_management/public/components/data_source_view/data_source_view.tsx b/src/plugins/data_source_management/public/components/data_source_view/data_source_view.tsx
@@ -25,7 +25,7 @@ import { DataSourceDropDownHeader } from '../drop_down_header';
 import { DataSourceItem } from '../data_source_item';
 import { LocalCluster } from '../constants';
 import './data_source_view.scss';
-import { PopoverButton } from '../popover_button/popover_button';
+import { DataSourceMenuPopoverButton } from '../popover_button/popover_button';
 
 interface DataSourceViewProps {
   fullWidth: boolean;
@@ -159,7 +159,7 @@ export class DataSourceView extends React.Component<DataSourceViewProps, DataSou
       <EuiPopover
         id={'dataSourceViewPopover'}
         button={
-          <PopoverButton
+          <DataSourceMenuPopoverButton
             className={'dataSourceView'}
             label={label}
             onClick={this.onClick.bind(this)}
@@ -177,7 +177,6 @@ export class DataSourceView extends React.Component<DataSourceViewProps, DataSou
               options={options}
               singleSelection={true}
               data-test-subj={'dataSourceView'}
-              compressed={true}
               renderOption={(option) => (
                 <DataSourceItem
                   option={option}