Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [MDS] Add Vega support for importing saved objects #6214

Merged
merged 2 commits into from
Mar 20, 2024

Merge branch '2.x' into backport/backport-6123-to-2.x

8aefa3a
Select commit
Loading
Failed to load commit list.
Merged

[Backport 2.x] [MDS] Add Vega support for importing saved objects #6214

Merge branch '2.x' into backport/backport-6123-to-2.x
8aefa3a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 20, 2024 in 1s

67.26% (+0.05%) compared to 05ede47

View this Pull Request on Codecov

67.26% (+0.05%) compared to 05ede47

Details

Codecov Report

Attention: Patch coverage is 85.71429% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 67.26%. Comparing base (05ede47) to head (8aefa3a).

Files Patch % Lines
...erver/saved_objects/import/create_saved_objects.ts 68.88% 10 Missing and 4 partials ⚠️
src/core/server/saved_objects/import/utils.ts 90.24% 2 Missing and 2 partials ⚠️
...d_objects/import/check_conflict_for_data_source.ts 80.00% 0 Missing and 2 partials ⚠️
src/plugins/vis_type_vega/server/utils.ts 95.23% 1 Missing and 1 partial ⚠️
...e_vega/server/vega_visualization_client_wrapper.ts 93.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #6214      +/-   ##
==========================================
+ Coverage   67.20%   67.26%   +0.05%     
==========================================
  Files        3332     3335       +3     
  Lines       64448    64579     +131     
  Branches    10293    10326      +33     
==========================================
+ Hits        43313    43438     +125     
- Misses      18635    18636       +1     
- Partials     2500     2505       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov