[Backport 2.x] [MDS] Add Vega support for importing saved objects #6214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add MDS support for Vega Signed-off-by: Huy Nguyen <[email protected]> * Refactor field to data_source_id Signed-off-by: Huy Nguyen <[email protected]> * Add to CHANGELOG.md Signed-off-by: Huy Nguyen <[email protected]> * Added test cases and renamed field to use data_source_name Signed-off-by: Huy Nguyen <[email protected]> * Add prefix datasource name test case and add example in default hjson Signed-off-by: Huy Nguyen <[email protected]> * Move CHANGELOG to appropriate section Signed-off-by: Huy Nguyen <[email protected]> * Increased test coverage of search() method Signed-off-by: Huy Nguyen <[email protected]> * Add test cases for util function Signed-off-by: Huy Nguyen <[email protected]> * Add util function to modify Vega Spec Signed-off-by: Huy Nguyen <[email protected]> * Add method to verify Vega saved object type Signed-off-by: Huy Nguyen <[email protected]> * Add import saved object support for Vega Signed-off-by: Huy Nguyen <[email protected]> * Add unit tests for Vega objects in create and conflict modes Signed-off-by: Huy Nguyen <[email protected]> * Refactored utils test file Signed-off-by: Huy Nguyen <[email protected]> * Add to CHANGELOG Signed-off-by: Huy Nguyen <[email protected]> * Use bulkget instead of single get Signed-off-by: Huy Nguyen <[email protected]> * Add datasource references to the specs Signed-off-by: Huy Nguyen <[email protected]> * Fix bootstrap errors Signed-off-by: Huy Nguyen <[email protected]> * Add edge case where title is potentially undefined Signed-off-by: Huy Nguyen <[email protected]> * Address PR comments Signed-off-by: Huy Nguyen <[email protected]> * Add more test coverage for checking conflict Signed-off-by: Huy Nguyen <[email protected]> * Fix unit test Signed-off-by: Huy Nguyen <[email protected]> --------- Signed-off-by: Huy Nguyen <[email protected]> (cherry picked from commit de978d4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
added
multiple datasource
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl and
BionIT
as code owners
BionIT
approved these changes
Mar 19, 2024
Flyingliuhub
approved these changes
Mar 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6214 +/- ##
==========================================
+ Coverage 67.20% 67.26% +0.05%
==========================================
Files 3332 3335 +3
Lines 64448 64579 +131
Branches 10293 10326 +33
==========================================
+ Hits 43313 43438 +125
- Misses 18635 18636 +1
- Partials 2500 2505 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 20, 2024
* Add MDS support for Vega Signed-off-by: Huy Nguyen <[email protected]> * Refactor field to data_source_id Signed-off-by: Huy Nguyen <[email protected]> * Add to CHANGELOG.md Signed-off-by: Huy Nguyen <[email protected]> * Added test cases and renamed field to use data_source_name Signed-off-by: Huy Nguyen <[email protected]> * Add prefix datasource name test case and add example in default hjson Signed-off-by: Huy Nguyen <[email protected]> * Move CHANGELOG to appropriate section Signed-off-by: Huy Nguyen <[email protected]> * Increased test coverage of search() method Signed-off-by: Huy Nguyen <[email protected]> * Add test cases for util function Signed-off-by: Huy Nguyen <[email protected]> * Add util function to modify Vega Spec Signed-off-by: Huy Nguyen <[email protected]> * Add method to verify Vega saved object type Signed-off-by: Huy Nguyen <[email protected]> * Add import saved object support for Vega Signed-off-by: Huy Nguyen <[email protected]> * Add unit tests for Vega objects in create and conflict modes Signed-off-by: Huy Nguyen <[email protected]> * Refactored utils test file Signed-off-by: Huy Nguyen <[email protected]> * Add to CHANGELOG Signed-off-by: Huy Nguyen <[email protected]> * Use bulkget instead of single get Signed-off-by: Huy Nguyen <[email protected]> * Add datasource references to the specs Signed-off-by: Huy Nguyen <[email protected]> * Fix bootstrap errors Signed-off-by: Huy Nguyen <[email protected]> * Add edge case where title is potentially undefined Signed-off-by: Huy Nguyen <[email protected]> * Address PR comments Signed-off-by: Huy Nguyen <[email protected]> * Add more test coverage for checking conflict Signed-off-by: Huy Nguyen <[email protected]> * Fix unit test Signed-off-by: Huy Nguyen <[email protected]> --------- Signed-off-by: Huy Nguyen <[email protected]> (cherry picked from commit de978d4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit d144637) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BionIT
pushed a commit
that referenced
this pull request
Mar 20, 2024
…6222) * Add MDS support for Vega * Refactor field to data_source_id * Add to CHANGELOG.md * Added test cases and renamed field to use data_source_name * Add prefix datasource name test case and add example in default hjson * Move CHANGELOG to appropriate section * Increased test coverage of search() method * Add test cases for util function * Add util function to modify Vega Spec * Add method to verify Vega saved object type * Add import saved object support for Vega * Add unit tests for Vega objects in create and conflict modes * Refactored utils test file * Add to CHANGELOG * Use bulkget instead of single get * Add datasource references to the specs * Fix bootstrap errors * Add edge case where title is potentially undefined * Address PR comments * Add more test coverage for checking conflict * Fix unit test --------- (cherry picked from commit de978d4) # Conflicts: # CHANGELOG.md (cherry picked from commit d144637) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ashwin P Chandran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport de978d4 from #6123.