[Backport 2.x] Refactor hardcode color to use OUI in maps_legacy
#4391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Refactor color to use OUI * Pull theme value from actual active theme * Update changelog --------- Signed-off-by: Matt Provost <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 0b54e84) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr and
abbyhu2000
as code owners
opensearch-trigger-bot
bot
added
the
autocut
opensearch-trigger-bot
bot
requested a review
from zengyan-amazon
as a code owner
opensearch-trigger-bot
bot
requested review from
zhongnansu,
manasvinibs,
ZilongX and
Flyingliuhub
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #4391 +/- ##
==========================================
- Coverage 66.40% 66.34% -0.06%
==========================================
Files 3245 3245
Lines 62400 62400
Branches 9663 9663
==========================================
- Hits 41435 41401 -34
- Misses 18625 18653 +28
- Partials 2340 2346 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joshuarrrr
approved these changes
Jun 26, 2023
|
both failures can be ignored. |
manasvinibs
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 0b54e84 from #4294.