[BUILD] Maps service config #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't fix the maps out of the box but fixes the issues that prevented users from settings the maps service in the config. Which can be set by adding: map.tilemap.url: "https://tiles.maps.search-services.aws.a2z.com/tiles/{z}/{x}/{y}.png" map.includeOpenSearchMapsService: false Signed-off-by: Kawika Avilla <[email protected]>
|
✅ DCO Check Passed 97cb55a |
Can that go in a subsequent PR? This fixes current functionality that is broken. |
kavilla
added a commit
that referenced
this pull request
May 21, 2021
This doesn't fix the maps out of the box but fixes the issues that prevented users from settings the maps service in the config. Which can be set by adding: map.tilemap.url: "https://tiles.maps.search-services.aws.a2z.com/tiles/{z}/{x}/{y}.png" map.includeOpenSearchMapsService: false Signed-off-by: Kawika Avilla <[email protected]>
SuZhou-Joe
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 25, 2024
…oject#6094) (opensearch-project#308) * feat: add comment * feat: update unit test * feat: add CHANGELOG * feat: optimize comment * feat: optimize comment * feat: optimize code * feat: optimize code --------- Signed-off-by: SuZhou-Joe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This doesn't fix the maps out of the box but fixes the issues that prevented users from settings the maps service in the config.
Which can be set by adding the following to opensearch_dashboards.yml:
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
Partial: #221
Check List