Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Maps show error #221

Closed
kavilla opened this issue Mar 23, 2021 · 3 comments · Fixed by #323
Closed

[BUG] Maps show error #221

kavilla opened this issue Mar 23, 2021 · 3 comments · Fixed by #323
Labels
bug Something isn't working
Milestone
Beta release

Comments

@kavilla
Copy link
Member

kavilla commented Mar 23, 2021 •
edited
Loading

Describe the bug
Calls to get map data errors out. While navigating to any page that makes a call to get map data it sends a request to a non-existent service. This is because the original URL for the service was replaced while the fork was undergoing renaming. This was expected bug to occur but will need to be fixed.

To Reproduce
Steps to reproduce the behavior:

  1. Load sample data
  2. Go to dashboards
  3. Go to a map widget
  4. See error

Expected behavior
Successful response to an existing service and it shows map data.

OpenSearch Version
n/a

Dashboards Version
1.x main

Plugins
n/a

Screenshots

Screen Shot 2021-03-23 at 9 47 44 AM

Host/Environment (please complete the following information):

  • OS: Ubuntu
  • Browser and version [e.g. 22]; Firefox 78.7.0esr

Additional context

Need to discuss with the community about what map service to use.
@kavilla kavilla added the bug Something isn't working label Mar 23, 2021
@mihirsoni mihirsoni mentioned this issue Apr 14, 2021
Closed
@mihirsoni
Copy link
Contributor

In order to solve this problem, there are multiple approach :

  • We provide guide to host user's own mapping server
  • Work with Amazon internal to see if OpenSource Dashboards can leverage the existing Tiles / Maps service.

CC: @nknize

@mihirsoni mihirsoni added this to the Beta release milestone Apr 15, 2021
kavilla added a commit to kavilla/OpenSearch-Dashboards that referenced this issue Apr 19, 2021
@kavilla
[Tests] ignore map-related functional tests
64cc159 
Ignore map related functional tests temporarily until we have a
replacement for EMS.

See: opensearch-project/OpenSearch-Dashboards#221

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit to kavilla/OpenSearch-Dashboards that referenced this issue Apr 21, 2021
@kavilla
[Tests] ignore map-related functional tests
3a486d1 
Ignore map related functional tests temporarily until we have a
replacement for EMS.

See: opensearch-project/OpenSearch-Dashboards#221

Signed-off-by: Kawika Avilla <[email protected]>
This was referenced Apr 21, 2021
Merged
Merged
mihirsoni pushed a commit that referenced this issue Apr 22, 2021
@kavilla
[Tests] Functional test updates (#304)
1bfa6e4 
* [Tests] ciGroup2 fully passing

Signed-off-by: Kawika Avilla <[email protected]>

* [Tests] updated ndjson files

Removing references to kibana

Signed-off-by: Kawika Avilla <[email protected]>

* [Tests] ignore map-related functional tests

Ignore map related functional tests temporarily until we have a
replacement for EMS.

See: #221

Signed-off-by: Kawika Avilla <[email protected]>

* [Tests] Update dashboards data to correct config

Signed-off-by: Kawika Avilla <[email protected]>

* [Tests] update ndjson to big to correct type

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
Copy link
Member Author

kavilla commented Apr 26, 2021

Currently, if you pull main, it will fail out of the box. But you can get the app to work if you add the following to the config/opensearch_dashboards.yml:

map.tilemap.url: "https://tiles.maps.search-services.aws.a2z.com/tiles/{z}/{x}/{y}.png"
map.includeOpenSearchMapsService: false

@kavilla
Copy link
Member Author

kavilla commented Apr 26, 2021

Will be sending a PR to make a new maps client that extends the current map client.

kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Apr 29, 2021
@kavilla
[BUILD] Update default maps client
308262a 
Update to not use EMS so it works out of the box.
Related to: opensearch-project#221

Fails linter and should problem write more unit tests but working with smoke tests.

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Apr 29, 2021
@kavilla
[Build] Update default maps client
19e3340 
Update to not use EMS so it works out of the box.
Related to: opensearch-project#221

Fails linter and should problem write more unit tests but working with smoke tests.

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla mentioned this issue Apr 29, 2021
Merged
5 tasks
@kavilla kavilla linked a pull request Apr 30, 2021 that will close this issue
Update map client #323
Merged
5 tasks
mihirsoni pushed a commit that referenced this issue Apr 30, 2021
@kavilla
[Maps] Update default map client (#323)
fb2f793 
* [Build] Update default maps client

Update to not use EMS so it works out of the box.
Related to: #221

Fails linter and should problem write more unit tests but working with smoke tests.

Signed-off-by: Kawika Avilla <[email protected]>

* [Build] fix linter for map messages

Signed-off-by: Kawika Avilla <[email protected]>

* [Build] enable and update map func tests

Passing on the CI. Needed to update the casing of the expected response
but that was all that was needed.

Signed-off-by: Kawika Avilla <[email protected]>

* [Rename] rename to osd_version

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla mentioned this issue May 11, 2021
Merged
5 tasks
kavilla added a commit that referenced this issue May 21, 2021
@kavilla
[Tests] Functional test updates (#304)
8835888 
* [Tests] ciGroup2 fully passing

Signed-off-by: Kawika Avilla <[email protected]>

* [Tests] updated ndjson files

Removing references to kibana

Signed-off-by: Kawika Avilla <[email protected]>

* [Tests] ignore map-related functional tests

Ignore map related functional tests temporarily until we have a
replacement for EMS.

See: #221

Signed-off-by: Kawika Avilla <[email protected]>

* [Tests] Update dashboards data to correct config

Signed-off-by: Kawika Avilla <[email protected]>

* [Tests] update ndjson to big to correct type

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this issue May 21, 2021
@kavilla
[Maps] Update default map client (#323)
f4da95a 
* [Build] Update default maps client

Update to not use EMS so it works out of the box.
Related to: #221

Fails linter and should problem write more unit tests but working with smoke tests.

Signed-off-by: Kawika Avilla <[email protected]>

* [Build] fix linter for map messages

Signed-off-by: Kawika Avilla <[email protected]>

* [Build] enable and update map func tests

Passing on the CI. Needed to update the casing of the expected response
but that was all that was needed.

Signed-off-by: Kawika Avilla <[email protected]>

* [Rename] rename to osd_version

Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Beta release
Development

Successfully merging a pull request may close this issue.

Update map client kavilla/OpenSearch-Dashboards-1
2 participants
@mihirsoni @kavilla