Sass lint #1413
Merged
Sass lint #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boktorbb
previously approved these changes
Apr 1, 2022
Yep. I also verified all the other manual css changes to make sure nothing else changed any styles. |
|
Some linter errors. |
* Introduces standard scss rules from stylelint with only a few modifications. * `yarn lint` now runs `yarn lint:style` instead of `yarn lint:sass`. * Many of the files were updated with `yarn lint:style --fix`, but some of them had to be manually updated with overrides to adhere to the newly-introduced rules from the stylelint configuration. * Includes a couple fixes such as fixing the class selector for `osdnSuggestionItem--value .osdSuggestionItem__text`. Resolves opensearch-project#551 Resolves opensearch-project#1139 Resolves opensearch-project#1151 Resolves opensearch-project#1152 Resolves opensearch-project#1154 Signed-off-by: Tommy Markley <[email protected]>
Signed-off-by: Ashwin Pc <[email protected]>
Signed-off-by: Ashwin Pc <[email protected]>
Signed-off-by: Ashwin Pc <[email protected]>
boktorbb
approved these changes
Apr 1, 2022
AMoo-Miki
approved these changes
Apr 1, 2022
7 tasks
ashwin-pc
added
v2.0.0
cve
|
@ashwin-pc you're awesome, thank you! |
8 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally from #1294 but fixes the failing tests in commit
757cbb525d045a47c34a5d7d7739826a8649bf80Description from original PR:
yarn lintnow runsyarn lint:styleinstead ofyarn lint:sass.yarn lint:style --fix, but some of them had to be manually updated with overrides to adhere to the newly-introduced rules from the stylelint configuration.osdnSuggestionItem--value .osdSuggestionItem__text.Issues Resolved
Resolves #551
Resolves #1139
Resolves #1151
Resolves #1152
Resolves #1154
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr