Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces sass-lint with stylelint #1294

Closed
wants to merge 1 commit into from
Closed

Replaces sass-lint with stylelint #1294

wants to merge 1 commit into from

Conversation

tmarkley
Copy link
Contributor

@tmarkley tmarkley commented Feb 28, 2022 •
edited
Loading

Description

  • Introduces standard scss rules from stylelint with only a few modifications.
  • yarn lint now runs yarn lint:style instead of yarn lint:sass.
  • Many of the files were updated with yarn lint:style --fix, but some of them had to be manually updated with overrides to adhere to the newly-introduced rules from the stylelint configuration.
  • Includes a couple fixes such as fixing the class selector for osdnSuggestionItem--value .osdSuggestionItem__text.

Issues Resolved

Resolves #551
Resolves #1139
Resolves #1151
Resolves #1152
Resolves #1154

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@tmarkley tmarkley added dependencies Pull requests that update a dependency file v2.0.0 labels Feb 28, 2022
@tmarkley tmarkley requested a review from a team as a code owner February 28, 2022 05:33
@tmarkley tmarkley force-pushed the sass-lint branch 3 times, most recently from 7323ddb to 6375426 Compare March 2, 2022 22:38
@tmarkley
Copy link
Contributor Author

tmarkley commented Mar 2, 2022

Trying to determine why some functional tests are now timing out.

@tmarkley tmarkley force-pushed the sass-lint branch 2 times, most recently from bf9be85 to 8a87b3f Compare March 4, 2022 00:59
@tmarkley tmarkley added the cve Security vulnerabilities detected by Dependabot or Mend label Mar 16, 2022
@tmarkley tmarkley force-pushed the sass-lint branch 3 times, most recently from e330932 to e8e1b14 Compare March 17, 2022 15:56
@tmarkley tmarkley marked this pull request as draft March 24, 2022 18:09
@tmarkley
Copy link
Contributor Author

Converting to draft until the functional test failures have been solved.

Replaces sass-lint with stylelint
c6457b1 
* Introduces standard scss rules from stylelint with only a few
  modifications.
* `yarn lint` now runs `yarn lint:style` instead of `yarn lint:sass`.
* Many of the files were updated with `yarn lint:style --fix`, but some
  of them had to be manually updated with overrides to adhere to the
  newly-introduced rules from the stylelint configuration.
* Includes a couple fixes such as fixing the class selector for
  `osdnSuggestionItem--value .osdSuggestionItem__text`.

Resolves opensearch-project#551
Resolves opensearch-project#1139
Resolves opensearch-project#1151
Resolves opensearch-project#1152
Resolves opensearch-project#1154

Signed-off-by: Tommy Markley <[email protected]>
@ashwin-pc ashwin-pc mentioned this pull request Apr 1, 2022
Merged
7 tasks
@ashwin-pc
Copy link
Member

Change merged in #1413. Closing this PR

@ashwin-pc ashwin-pc closed this Apr 1, 2022
@tmarkley tmarkley deleted the sass-lint branch April 16, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh Awaiting requested review from ananzh ananzh will be requested when the pull request is marked ready for review ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla will be requested when the pull request is marked ready for review kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki will be requested when the pull request is marked ready for review AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc will be requested when the pull request is marked ready for review ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr will be requested when the pull request is marked ready for review joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 will be requested when the pull request is marked ready for review abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon will be requested when the pull request is marked ready for review zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu will be requested when the pull request is marked ready for review zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs will be requested when the pull request is marked ready for review manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX will be requested when the pull request is marked ready for review ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub will be requested when the pull request is marked ready for review Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq will be requested when the pull request is marked ready for review curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn will be requested when the pull request is marked ready for review bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe will be requested when the pull request is marked ready for review SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl will be requested when the pull request is marked ready for review ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT will be requested when the pull request is marked ready for review BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba will be requested when the pull request is marked ready for review xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi will be requested when the pull request is marked ready for review zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric will be requested when the pull request is marked ready for review mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 will be requested when the pull request is marked ready for review LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi will be requested when the pull request is marked ready for review virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli will be requested when the pull request is marked ready for review sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 will be requested when the pull request is marked ready for review joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo will be requested when the pull request is marked ready for review huyaboo is a code owner

Assignees
No one assigned
Labels
cve Security vulnerabilities detected by Dependabot or Mend dependencies Pull requests that update a dependency file v2.0.0
Projects
None yet
Milestone
No milestone
2 participants
@tmarkley @ashwin-pc