Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy way to replace OpenSearch Dashboards "logo" #798

Closed
bluepeter opened this issue Sep 15, 2021 · 4 comments
Closed

Easy way to replace OpenSearch Dashboards "logo" #798

bluepeter opened this issue Sep 15, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@bluepeter
Copy link

Searching around, there are various complex ways to update the OS logo that lives in the top-left. It would be super if there was a way to easily update the logo and other design elements in Stack Management > Advanced Settings (this would also allow us to update the logo as part of AWS OpenSearch Service).

Messing around with the logo is explicitly against Elastic's TOS, so we appreciate the flexibility we have with OSD to allow for this customization. However, there's not an easy or straightforward way to do this?

@bluepeter bluepeter added the enhancement New feature or request label Sep 15, 2021
@ahopp
Copy link
Contributor

ahopp commented Sep 15, 2021

I think this is related to this proposal: #725

@bluepeter Can you take a look and see if that covers your ask?

@bluepeter
Copy link
Author

Thank you @ahopp for that reference. This would mostly solve our issue. However, instead of relying on a separate .yaml file, we'd love an easy way to adjust the logo (and/or insert custom CSS/JS) from the OS Dashboards interface itself. This would then allow us to still use AWS OpenSearch Service, versus having to deploy the solution via container to support a separate file (which I don't believe is possible via AWS OS).

@abbyhu2000
Copy link
Member

@bluepeter Thank you for your feedback! Currently making branding configuration into OSD interface/Advanced settings will need more time and consideration because of the implications with other plugins.

For example, if user installs security plugin, user will be able to switch among different tenants. However, the advanced setting is saved using the .kibana index and each tenant has its own unique .kibana index. Therefore, if user sets the advanced setting in one tenant, only that tenant will render that specific branding customization. When user switch out to another tenant, user will see a different dashboard UI if the branding configuration in that tenant are set differently. We are currently not sure if we wish this type of user experience so we are holding off on incorporating branding configurations under Advances Settings.

Therefore, yaml file will be the starting point and foundation for a more user-friendly branding customization solution in the future.

@bluepeter
Copy link
Author

@abbyhu2000 makes sense. Closing for now.

AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
# [24.0.0](elastic/elastic-charts@v23.2.1...v24.0.0) (2020-10-19)

### Bug Fixes

* **annotation:** annotation rendering with no yDomain or groupId ([opensearch-project#842](elastic/elastic-charts#842)) ([6bad0d7](elastic/elastic-charts@6bad0d7)), closes [opensearch-project#438](elastic/elastic-charts#438) [opensearch-project#798](elastic/elastic-charts#798)

### Features

* **bar_chart:** add Alignment offset to value labels ([opensearch-project#784](elastic/elastic-charts#784)) ([106d924](elastic/elastic-charts@106d924))
* **bar_chart:** add shadow prop for value labels ([opensearch-project#785](elastic/elastic-charts#785)) ([de95b44](elastic/elastic-charts@de95b44))
* **bar_chart:** scaled font size for value labels ([opensearch-project#789](elastic/elastic-charts#789)) ([8b74a9d](elastic/elastic-charts@8b74a9d)), closes [opensearch-project#788](elastic/elastic-charts#788)
* **heatmap:** allow fixed right margin ([opensearch-project#873](elastic/elastic-charts#873)) ([dd34574](elastic/elastic-charts@dd34574))

### BREAKING CHANGES

* **bar_chart:** The `DisplayValueStyle` `fontSize` property can now express an upper and lower bound as size, used for the automatic scaling.
* **bar_chart:** The `DisplayValueStyle` `fill` property can now express a border color and width, or let the library pick the best match based on contrast using the textInvertible parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants