Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rect Annotation should fallback to full height/width #798

Closed
nickofthyme opened this issue Sep 2, 2020 · 1 comment
Closed

Rect Annotation should fallback to full height/width #798

nickofthyme opened this issue Sep 2, 2020 · 1 comment
Assignees
@rshen91
Labels
:annotation Annotation (line, rect, text) related issue bug Something isn't working :xy Bar/Line/Area chart related

Comments

@nickofthyme
Copy link
Collaborator

Describe the bug
When using x or y axes with a groupId along with a RectAnnotation. If no groupId is set on the RectAnnotation it will not appear as there is no __global__ groupId fallback to determine the correct fallback height.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/s/cool-cookies-s8okq?file=/src/App.tsx
  2. Notice how toggling the groupId on the RectAnnotation hides and shows

Expected behaviour
When no x or y axis groupId is determinable, it should fallback to the chart dimensions.
@nickofthyme nickofthyme added bug Something isn't working :annotation Annotation (line, rect, text) related issue :xy Bar/Line/Area chart related labels Sep 2, 2020
@nickofthyme nickofthyme self-assigned this Sep 2, 2020
@nickofthyme nickofthyme assigned rshen91 and unassigned nickofthyme Oct 1, 2020
@rshen91 rshen91 mentioned this issue Oct 1, 2020
Merged
2 tasks
rshen91 added a commit that referenced this issue Oct 12, 2020
@rshen91
fix(annotation): annotation rendering with no yDomain or groupId (#842)
f173b49 
fixes #438, #798
Co-authored-by: nickofthyme <[email protected]>
markov00 pushed a commit that referenced this issue Oct 19, 2020
@semantic-release-bot
chore(release): 24.0.0 [skip ci]
eda6889 
# [24.0.0](v23.2.1...v24.0.0) (2020-10-19)

### Bug Fixes

* **annotation:** annotation rendering with no yDomain or groupId ([#842](#842)) ([f173b49](f173b49)), closes [#438](#438) [#798](#798)

### Features

* **bar_chart:** add Alignment offset to value labels ([#784](#784)) ([363aeb4](363aeb4))
* **bar_chart:** add shadow prop for value labels ([#785](#785)) ([9b29392](9b29392))
* **bar_chart:** scaled font size for value labels ([#789](#789)) ([3bdd1ee](3bdd1ee)), closes [#788](#788)
* **heatmap:** allow fixed right margin ([#873](#873)) ([16cf73c](16cf73c))

### BREAKING CHANGES

* **bar_chart:** The `DisplayValueStyle` `fontSize` property can now express an upper and lower bound as size, used for the automatic scaling.
* **bar_chart:** The `DisplayValueStyle` `fill` property can now express a border color and width, or let the library pick the best match based on contrast using the textInvertible parameter.
@nickofthyme
Copy link
Collaborator Author

Closed by #842

AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 24.0.0 [skip ci]
3b372d8 
# [24.0.0](elastic/elastic-charts@v23.2.1...v24.0.0) (2020-10-19)

### Bug Fixes

* **annotation:** annotation rendering with no yDomain or groupId ([opensearch-project#842](elastic/elastic-charts#842)) ([6bad0d7](elastic/elastic-charts@6bad0d7)), closes [opensearch-project#438](elastic/elastic-charts#438) [opensearch-project#798](elastic/elastic-charts#798)

### Features

* **bar_chart:** add Alignment offset to value labels ([opensearch-project#784](elastic/elastic-charts#784)) ([106d924](elastic/elastic-charts@106d924))
* **bar_chart:** add shadow prop for value labels ([opensearch-project#785](elastic/elastic-charts#785)) ([de95b44](elastic/elastic-charts@de95b44))
* **bar_chart:** scaled font size for value labels ([opensearch-project#789](elastic/elastic-charts#789)) ([8b74a9d](elastic/elastic-charts@8b74a9d)), closes [opensearch-project#788](elastic/elastic-charts#788)
* **heatmap:** allow fixed right margin ([opensearch-project#873](elastic/elastic-charts#873)) ([dd34574](elastic/elastic-charts@dd34574))

### BREAKING CHANGES

* **bar_chart:** The `DisplayValueStyle` `fontSize` property can now express an upper and lower bound as size, used for the automatic scaling.
* **bar_chart:** The `DisplayValueStyle` `fill` property can now express a border color and width, or let the library pick the best match based on contrast using the textInvertible parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rshen91 rshen91

Labels
:annotation Annotation (line, rect, text) related issue bug Something isn't working :xy Bar/Line/Area chart related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickofthyme @rshen91