Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't skip embedOptions for parameterless recipes #68

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Don't skip embedOptions for parameterless recipes #68

merged 1 commit into from
Jan 27, 2024

Conversation

Bananeweizen
Copy link
Contributor

Deduplicate the logic for creating the recipe code to avoid an inconcistency in how the embedOptions are used.

Fixes #66.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@Bananeweizen
Don't skip embedOptions for parameterless recipes
58db7db 
Deduplicate the logic for creating the recipe code to avoid an
inconcistency in how the embedOptions are used.

Fixes openrewrite#66.
knutwannheden
knutwannheden approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@knutwannheden knutwannheden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@knutwannheden knutwannheden merged commit aa1fb10 into openrewrite:main Jan 27, 2024
1 check passed
@Bananeweizen Bananeweizen deleted the shorten_names branch January 28, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knutwannheden knutwannheden knutwannheden approved these changes

Assignees

@Bananeweizen Bananeweizen

Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing SHORTEN_NAMES for parameterless recipes
2 participants
@Bananeweizen @knutwannheden