missing SHORTEN_NAMES for parameterless recipes

[Bananeweizen]

What is the smallest, simplest way to reproduce the problem?

        @BeforeTemplate
        String before() {
            return "foo";
        }

        @AfterTemplate
        String after() {
            return SomeClass.SOME_CONSTANT;
        }

What did you expect to see?

The generated recipe should contain SHORTEN_NAMES. It's meant to be generated with every recipe, according to

rewrite-templating/src/main/java/org/openrewrite/java/template/processor/RefasterTemplateProcessor.java

Line 272 in 0e4a144

embedOptions.add("SHORTEN_NAMES");

What did you see instead?

No additional recipe references. Therefore running the recipe leads to a FQN for SomeClass.SOME_CONSTANT. (Workaround: Add the ShortenFullyQualifiedTypeReferences to the recipe list explicitly).

Root cause is

rewrite-templating/src/main/java/org/openrewrite/java/template/processor/RefasterTemplateProcessor.java

Line 278 in 0e4a144

recipe.append(" return embed(").append(after).append(".apply(getCursor(), elem.getCoordinates().replace()), getCursor(), ctx);\n");

not adding the embedOptions collection (it does this correctly in https://github.com/openrewrite/rewrite-templating/blob/main/src/main/java/org/openrewrite/java/template/processor/RefasterTemplateProcessor.java#L284).

Are you interested in contributing a fix to OpenRewrite?

Yes. I would combine the 2 code blocks to remove the code duplication, since such code duplications will lead to similar failures again.

[timtebeek]

Thanks for the in depth look and offer to help @Bananeweizen ; do you want me to assign this issue to you then?

[Bananeweizen]

Yes, I already started debugging this, but might take a bit more of my spare time to get used to the environment.

[timtebeek]

Sure! Appreciate you exploring a type of recipe we hadn't tested before. Looking over the example once more it seems like a reimplementation of Replace String literal with constant, but with compile time checking; neat!