Add recipe to migrate ResponseStatusException changes
#598
Conversation
|
@Laurens-W any input from your side here seeing that you recently added this similar Anything we can reuse from there for instance? |
.../openrewrite/java/spring/framework/MigrateResponseStatusExceptionGetRawStatusCodeMethod.java
Show resolved
Hide resolved
.../openrewrite/java/spring/framework/MigrateResponseStatusExceptionGetRawStatusCodeMethod.java
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
.../openrewrite/java/spring/framework/MigrateResponseStatusExceptionGetRawStatusCodeMethod.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/spring/framework/MigrateResponseStatusExceptionTest.java
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| import org.springframework.web.server.ResponseStatusException; | ||
| class A { | ||
| void foo(ResponseStatusException e) { | ||
| HttpStatus i = e.getStatusCode(); |
There was a problem hiding this comment.
I think this ought to be HttpStatusCode instead of HttpStatus, as per:
https://docs.spring.io/spring-framework/docs/6.0.0/javadoc-api/org/springframework/web/ErrorResponseException.html#getStatusCode()
There was a problem hiding this comment.
@Laurens-W is that something you can work in based on your earlier work on #589 ?
There was a problem hiding this comment.
Merging this iteration already as it's an improvement already; we'd need to change the test in a follow up PR to expect the variable and import change, and create a new dedicated recipe to handle the ResponseStatusException getStatus().
.../openrewrite/java/spring/framework/MigrateResponseStatusExceptionGetRawStatusCodeMethod.java
Outdated
Show resolved
Hide resolved
| displayName: Migrate breaking changes in `ResponseStatusException` | ||
| description: Migrate Spring Framework 5.3's `ResponseStatusException` method `getRawStatusCode()` to Spring Framework 6's `getStatusCode().value()` and `ResponseStatusException` method `getStatus()` to Spring Framework 6's `getStatusCode()` . | ||
| recipeList: | ||
| - org.openrewrite.java.spring.framework.MigrateResponseStatusExceptionGetRawStatusCodeMethod |
There was a problem hiding this comment.
Perhaps once the recipe for getStatus to getStatusCode is in place these could be included below line 33, or the recipe on line 33 could be pulled into here and this sub recipe could be transformed into a HttpStatus to HttpStatusCode recipe
What's changed?
Add recipe to migrate breaking changes introduced in Spring Framework 6.0 touching
ResponseStatusExceptionclass.What's your motivation?
Anything in particular you'd like reviewers to focus on?
Was not sure where to put the recipes - I added them to
spring-framework-60.ymlas another group (? - let me know correct naming here)Checklist