Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HttpStatus to HttpStatusCode in ResponseEntityExceptionHandler implementations #589

Merged
merged 21 commits into from
Sep 19, 2024

Conversation

Laurens-W
Copy link
Contributor

@Laurens-W Laurens-W commented Sep 9, 2024

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

@timtebeek

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@Laurens-W Laurens-W requested a review from timtebeek September 9, 2024 12:15
@Laurens-W Laurens-W self-assigned this Sep 9, 2024
@Laurens-W Laurens-W added enhancement New feature or request recipe Recipe requested boot-3.0 labels Sep 9, 2024
Laurens-W and others added 2 commits September 9, 2024 14:24
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Laurens-W and others added 3 commits September 9, 2024 16:29
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Laurens-W Laurens-W requested a review from timtebeek September 18, 2024 11:53
@Laurens-W Laurens-W marked this pull request as ready for review September 18, 2024 11:53
@Laurens-W Laurens-W requested a review from timtebeek September 18, 2024 15:49
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see this covered in rewrite-spring; thanks for picking it up!

@timtebeek
Copy link
Contributor

Failure also seen on main; let's pick that up separately. Thanks again!

@timtebeek timtebeek merged commit 8609f0c into main Sep 19, 2024
1 of 2 checks passed
@timtebeek timtebeek deleted the http-status-code-for-response-exception branch September 19, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boot-3.0 enhancement New feature or request recipe Recipe requested
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Spring 6] Add a recipe to switch from HttpStatus to HttpStatusCode for WebMVC customizations
2 participants