Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore generated pom by maven-shade-plugin and ci-friendly-flatten-maven-plugin #908

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

philippe-granet
Copy link
Contributor

@philippe-granet philippe-granet commented Dec 7, 2024

What's changed?

Exclude pom generated by org.apache.maven.plugins:maven-shade-plugin and com.outbrain.swinfra:ci-friendly-flatten-maven-plugin

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek
Copy link
Contributor

Nice find @philippe-granet ! I'd completely missed we already had special handling for some of these other alternative poms. Seems like the perfect place to add these exceptional cases as well. I've collapsed the conditionals you added to reduce duplication and ensure there's no surprises if the original pom files are missing. I trust that's no issue, but let me know if that was intentional on your side. Thanks again!

@timtebeek timtebeek added bug Something isn't working enhancement New feature or request labels Dec 7, 2024
@timtebeek timtebeek merged commit ab0ed4b into openrewrite:main Dec 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Cant' exclude dependency-reduced-pom.xml
2 participants