Cant' exclude dependency-reduced-pom.xml

[philippe-granet]

What version of OpenRewrite are you using?

I am using

• OpenRewrite v8.8.4
• Maven plugin v5.10.0

How are you running OpenRewrite?

I am using the Maven plugin, and my project is a single module project.

<plugin>
  <groupId>org.openrewrite.maven</groupId>
  <artifactId>rewrite-maven-plugin</artifactId>
  <version>8.8.4</version>
</plugin>

What is the smallest, simplest way to reproduce the problem?

Use Maven Shade plugin and add dependency-reduced-pom.xml to excluded files (-Drewrite.exclusions=dependency-reduced-pom.xml)

What did you expect to see?

No patch generated for dependency-reduced-pom.xml

What did you see instead?

Patch generated for dependency-reduced-pom.xml

[Bananeweizen]

I've also not been able to use exclusions successfully. I have this configuration to match folders like src-gen and similar, but generated files are still modified:

<exclusions>
	<!-- generated code -->
	<exclusion>**/*-gen/**</exclusion>
</exclusions>

[timtebeek]

Hmm; the reason for this will be that we ask Maven what files to process, and likely this is one of the files returned.

rewrite-maven-plugin/src/main/java/org/openrewrite/maven/MavenMojoProjectParser.java

Lines 150 to 153 in d1b68cd

	Map<MavenProject, List<Marker>> projectProvenances = mavenSession.getProjects().stream()
	.collect(Collectors.toMap(Function.identity(), this::generateProvenance));
	Map<MavenProject, Xml.Document> projectMap = parseMaven(mavenSession.getProjects(), projectProvenances, ctx);
	return mavenSession.getProjects().stream()

rewrite-maven-plugin/src/main/java/org/openrewrite/maven/MavenMojoProjectParser.java

Lines 463 to 467 in d1b68cd

	Set<Path> allPoms = new LinkedHashSet<>();
	mavenProjects.forEach(p -> collectPoms(p, allPoms));
	for (MavenProject mavenProject : mavenProjects) {
	mavenSession.getProjectDependencyGraph().getUpstreamProjects(mavenProject, true).forEach(p -> collectPoms(p, allPoms));
	}

The Maven shade plugin dependency-reduced-pom.xml has bitten me in the past as well, but went away when I added -DuseDependencyReducedPomInJar=false. Does that work for you as well @philippe-granet ?

[timtebeek]

Just a quick note here that @rickie has reported seeing the same issue with ci-friendly-flatten-maven-plugin. Any fix ideally takes both into account, to fall back to the original pom.xml, not any modified pom.

[philippe-granet]

The Maven shade plugin dependency-reduced-pom.xml has bitten me in the past as well, but went away when I added -DuseDependencyReducedPomInJar=false. Does that work for you as well @philippe-granet ?

In my case, developer have commited dependency-reduced-pom.xml ...

I propose this MR to fix the problem:

• Ignore generated pom by maven-shade-plugin and ci-friendly-flatten-maven-plugin #908

[rickie]

Thanks @timtebeek for taking that case into account 😄 !