Add JCL to Log4j API migration #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a recipe to migrate from Apache Commons Logging to Log4j 2.x API.
timtebeek
approved these changes
Dec 11, 2023
|
Good to have you here @ppkarwasz ! Thanks for adding this migration to Log4j2 and glad to see you were able to reuse so many components. Always welcome to add more if that helps you there! |
|
We usually release every two weeks or so, but can do point releases in between if that helps you there. In any case you can already try our snapshot versions. Thanks again! |
|
And it sounds like you might be interested in this community request: |
|
Thanks for the lightning-fast review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This PR adds a recipe to migrate from Apache Commons Logging to Log4j 2.x API:
org.openrewrite.java.logging.log4j.CommonsLoggingToLog4j.What's your motivation?
While it has an excellent SLF4J support
rewrite-logging-frameworksis somehow lacking vis-à-vis Log4j 2.x API support.As part of apache/logging-log4j2#2080 we plan to cover all conversions between the most popular logging APIs and Log4j API and between the most popular logging backends and Log4j Core. I would appreciate if these recipes could be included in an official OpenRewrite artifact.
Checklist