-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logback to log4j2 support #97
Comments
hi @Misha123456 ! We had not planned to support a migration from logback to log4j2, but are open to contributions in case you're interested to pick that up. Implementation wise I imagine it will be very similar to the log4j2 -> logback recipes. If you're merely looking to switch dependencies you could have a look at META-INF/rewrite/logback.yml, but a full migration might also involve converting for instance |
Could you assign this issue to me? I would split it into two independent recipes:
|
Sure sounds good; Thanks for taking this on! |
This PR adds a rule to convert code written with SLF4J 1.x/2.x to Log4j API. It covers: * basic `Logger` methods, * compatible `LogBuilder/LoggingEventBuilder` methods, * `MDC` to `ThreadContext` conversion, * `Marker` conversion, * dependency switch from `slf4j-api` to `log4j-api`. Solves part of openrewrite#97: it **does** not cover conversion between Logback and Log4j Core, since the choice of a logging implementation is **totally** independent from the choice of the API.
* Add SLF4J 2.x to Log4j API rewrite rule This PR adds a rule to convert code written with SLF4J 1.x/2.x to Log4j API. It covers: * basic `Logger` methods, * compatible `LogBuilder/LoggingEventBuilder` methods, * `MDC` to `ThreadContext` conversion, * `Marker` conversion, * dependency switch from `slf4j-api` to `log4j-api`. Solves part of #97: it **does** not cover conversion between Logback and Log4j Core, since the choice of a logging implementation is **totally** independent from the choice of the API. * Indent tests as per project convention --------- Co-authored-by: Tim te Beek <[email protected]>
We recently completed quite a few recipes to move from JUL to SLF4J; those are now under: I suspect that the approach taken there could be largely followed here: Mostly use declarative or Refaster recipes, and complement those with explicit recipes as needed, which wouldn't need much. |
We have recently revamped our documentation with:
Unlike the migration from JUL to SLF4J, which requires mostly code changes, migrating from Logback to Log4j Core requires:
The latter requires most of the work, since the configuration options of every standard Logback plugin must be matched to the corresponding options of a Log4j Core plugin. Starting October 2024, I plan to add support for a Logback-to-Log4j Core configuration conversion to the |
Nice to see, thanks! Spotted this note in the docs that ought to be an easy recipe for your users too.
|
I was reading the documentation here and can see log4j2 to logback conversion is supported.
But there is no way to convert vice versa (from logback to log4j2).
Are there plans to implement this in the future?
The text was updated successfully, but these errors were encountered: