This repository has been archived by the owner on Jan 1, 2020. It is now read-only.
[WIP] Better support of content creation #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
well, I think for the AbstractMapper it's not really generic enough. But couldn't this code be in BaseDoctrineRdfMapper just as easily? |
|
I just noticed that I no longer get notifications for this PR for some reason, but I don't really have much to add here anyways :-) From my POV, everything looks good, so if you want me to merge, just let me know! |
|
Alright, merging as requested. BTW, just a small heads-up: I will be on vacation for the rest of January without real network access, so if there's anything else that is urgent, better say it now :-) |
flack
added a commit
that referenced
this pull request
Jan 9, 2013
[WIP] Better support of content creation
|
Great, thanks for the collaboration, and enjoy your vacations! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor additions are needed in createphp in order to be able to create routes documents.
This PR is linked to symfony-cmf/cmf-sandbox#143 and symfony-cmf/create-bundle#24.
Do not merge this PR for now, it has been created to synchronize the work in progress.