[WIP] Handling of CreateJs on the CMF website #9

adou600 · 2012-10-11T09:40:57Z

Those wanting to try out content creation, go to /login and use editor as the username and dummy as the password, then go to /news and click edit and scroll to the bottom. You will see an add button (actually currently 4 due to a bug) to add a new news item.

Until the feedback and merge of the other repositories, I will continue to work on the following:

figure out how to deal with the existing content if saving from the news overview page
figure out why there are two "add" buttons for collections
fix the footer layout on the news overview page
take the modification date into account when saving and create a new element or updating some
use another sioc property than post to be able to differentiate the news and page, and then enable the CreateJs modification of the pages

This discussion can be helpful: openpsa/createphp#26

lsmith77 · 2012-10-11T09:52:02Z

before we can merge/deploy this we also need to add a simple login form. guess it can just use basic auth with a password set inside the parameters.yml. which also means we need to rename the parameters.yml and add an ignore on it.

… cmf Conflicts: src/Cmf/MainBundle/Resources/views/Cms/news_overview.html.twig

adou600 · 2012-10-17T15:06:25Z

app/config/security.yml

+        my_memory_provider:
+            memory:
+                users:
+                    editor: { password: dummy, roles: 'ROLE_EDITOR' }


@lsmith77 how can we handle the login and password for the site on production? I went for the memory providers since it's the easiest way to deal with user authentication. To login, you just need to go to the URL cmf.symfony.com/login. Don't hesitate to tell me if you see a better way to do it.

adou600 · 2013-01-04T14:17:51Z

@lsmith77 FMPOV, now we just need to decide what we do with the Create.js bugs listed at the end of #9 (comment). I think that when openpsa/createphp#29 and openpsa/createphp#44 will be closed some of the problems listed will disappear. The usability is not very good because of that, but it is still possible to add news... WDYT?

lsmith77 · 2013-01-04T16:02:32Z

i think we should push on .. we are not yet in a stable state .. to anything that moves us forward is good and will increase the chances of more people joining to help us fix the remaining issues.

lsmith77 · 2013-01-04T22:19:02Z

if @dbu does not have any objections i say we merge this!

dbu · 2013-01-09T14:46:38Z

yes i think it makes sense to merge. this has grown quite long.

does it depend on the createphp PR to be merged too?

the only worry i have is that if we actually start to use it, we also need to ensure we back up data and that we do not destroy data by reloading the fixtures. is this handled?

adou600 · 2013-01-10T08:54:36Z

@dbu it is not concerned by the last changes on createphp (openpsa/createphp#45) because it is only needed for the route creation on the Sandbox. But it has been closed anyway.

I can't do a lot about backups, but tell me if I can do something about the fixtures. There are still quite useful to debug and develop, but I indeed see the danger to keep it like this... Would a check during the fixture loading about the current environment be enough?

lsmith77 · 2013-01-10T08:57:31Z

we can probably talk to server grove about this as they host the CMF website. @pgodel ?

Adrien Nicolet [email protected] wrote:

@dbu it is not concerned by the last changes on createphp (openpsa/createphp#45) because it is only needed for the route creation on the Sandbox. But it has been closed anyway.

I can't do a lot about backups, but tell me if I can do something about the fixtures. There are still quite useful to debug and develop, but I indeed see the danger to keep it like this... Would a check during the fixture loading about the current environment be enough?

—
Reply to this email directly or view it on GitHub.

lsmith77 · 2013-03-07T21:59:52Z

src/Cmf/MainBundle/Resources/views/layout.html.twig

@@ -14,6 +14,11 @@
        <script src="http://html5shim.googlecode.com/svn/trunk/html5.js"></script>
        <![endif]-->
    {% endblock %}
+    {% if is_granted('ROLE_EDITOR') %}


i think this check would not be necessary if you would use https://github.com/symfony-cmf/CreateBundle/blob/master/DependencyInjection/Configuration.php#L30

What do you mean? I don't see how I can produce the same effect with IS_AUTHENTICATED_ANONYMOUSLY.

what I was trying to tell you is to configure the role via the config.yml so that you don't need to check it in the template

adou600 · 2013-03-09T14:01:39Z

After this commit I can't add news anymore. There is a weird issue with create.js when I click add.

I can't figure out what is happening. Any idea? Did we miss important changes in Create.js?

dbu · 2013-03-09T17:01:47Z

the create.js version is only controlled by the submodule that CreateBundle specifies. i suggest you try to manually use older versions of createjs using the git log and git checkout specific commit ids to see when it starts, and maybe the change indicates what goes wrong. if there are many commits, you could use git bisect between the version of createjs the version of createbundle before this update had.

dbu · 2013-03-18T06:35:21Z

hi @adou600 did you have any luck figuring out what the problem is, when it started or what could be done? if you want to pass by the office to have a look together, contact me on skype or irc, could take an hour today, tomorrow or wednesday. afterwards i am in holidays and staying in bern (where we could meet but its a bit far...)

adou600 · 2013-03-22T14:17:34Z

My bad, I didn't update the twig template used to display the news... There are now using the noautotag attribute and the creation of news with create.js is working fine again.

However, I had to manually rebase the jms/Serializer. I should use the version 0.12 but the CreateBundle allows 0.11.

dbu · 2013-03-22T14:52:48Z

great! if you are sure about CreateBundle and the serializer version, can you please create a pull request so we do not have wrong dependencies there?

are you working on the refactoring of createphp? oh, but that would not be needed for this feature as the website is single language. would this be ready to merge?

adou600 · 2013-03-22T15:01:23Z

I'm not sure about this serializer version... May be someone should try to checkout the project and see if it works on his machine as well. I think this is the only thing left to do for this PR.

lsmith77 · 2013-03-22T15:29:37Z

well i think composer is just having some issues with conflicts. CreateBundle does indeed work with 0.11 and 0.12 .. but FOSRestBundle does not. i guess the quick fix would be to just configure CreateBundle to require 0.12 .. but actually there is a bug in composer that is causing the issue.

see https://twitter.com/lsmith/status/315081682908753920 /cc @Seldaek

dbu · 2013-04-18T13:25:37Z

@lsmith77 you wanted to do something with the migrations tool. and think about the backup.

adou600 and others added 8 commits October 3, 2012 10:33

WIP - first experiments with CreatePHP

ba186d9

use of CreatePHP in templates

ef85a24

clean up

20c4f16

preparing for news collections and updating create bundle cleanup

a6306ed

WIP adding create.js and collections

122ba74

make fos restbundle handle json for the REST controller

ef8ad92

new test for collection handling

9f276aa

creation of news with CreateJs

cb3625a

adou600 and others added 14 commits October 11, 2012 16:50

show content when adding a news

b2fe584

WIP - first experiments with CreatePHP

aef278c

use of CreatePHP in templates

f321971

clean up

d190ced

preparing for news collections and updating create bundle cleanup

bc5e60a

WIP adding create.js and collections

234b50a

make fos restbundle handle json for the REST controller

d2482db

new test for collection handling

13ae14b

creation of news with CreateJs

8bf34fa

show content when adding a news

a919fd7

use CreateJs event to show the news content on edit

d99d14f

Merge branch 'cmf' of github.com:symfony-cmf/symfony-cmf-website into…

e481b67

… cmf Conflicts: src/Cmf/MainBundle/Resources/views/Cms/news_overview.html.twig

wip integration of a login to edit the content

d40573d

finalization of to edit the content

f9ef4aa

adou600 reviewed Oct 17, 2012
View reviewed changes

adou600 added 5 commits October 18, 2012 09:07

login password in parameters.yml.dist

b3ca979

1st attempt with homemande NS for news

a34418c

modification of content pages with createjs and schema.org vocabulary

454b2ef

test corrections to fit new vocabulary

023e165

test case for page update

4da8044

adou600 mentioned this pull request Dec 18, 2012

improve granular rendering openpsa/createphp#29

Open

adou600 mentioned this pull request Jan 4, 2013

Provide full access to node rendering API in Twig extension openpsa/createphp#44

Closed

handle frontend wrong creation date problem

d652cae

dependencies update

43b6758

dependencies update

be50db7

ghost assigned adou600 Jan 24, 2013

dbu and others added 2 commits February 21, 2013 17:06

Merge remote-tracking branch 'origin/master' into cmf

b39439b

Merge branch 'master' into cmf

6871f1c

lsmith77 reviewed Mar 7, 2013
View reviewed changes

update dependencies and fix layout bugs

19d34b4

adou600 added 2 commits March 22, 2013 14:46

update dependencies

e777632

update news list twig to fit the latest changes on createphp

bf004af

lsmith77 added the in progress label Aug 15, 2014

lsmith77 added ready and removed in progress labels May 1, 2015

lsmith77 added the wip/poc label May 11, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Handling of CreateJs on the CMF website #9

[WIP] Handling of CreateJs on the CMF website #9

adou600 commented Oct 11, 2012

lsmith77 commented Oct 11, 2012

adou600 Oct 17, 2012

adou600 commented Jan 4, 2013

lsmith77 commented Jan 4, 2013

lsmith77 commented Jan 4, 2013

dbu commented Jan 9, 2013

adou600 commented Jan 10, 2013

lsmith77 commented Jan 10, 2013

lsmith77 Mar 7, 2013

adou600 Mar 9, 2013

lsmith77 Mar 9, 2013

adou600 commented Mar 9, 2013

dbu commented Mar 9, 2013

dbu commented Mar 18, 2013

adou600 commented Mar 22, 2013

dbu commented Mar 22, 2013

adou600 commented Mar 22, 2013

lsmith77 commented Mar 22, 2013

dbu commented Apr 18, 2013

[WIP] Handling of CreateJs on the CMF website #9

Are you sure you want to change the base?

[WIP] Handling of CreateJs on the CMF website #9

Conversation

adou600 commented Oct 11, 2012

lsmith77 commented Oct 11, 2012

adou600 Oct 17, 2012

Choose a reason for hiding this comment

adou600 commented Jan 4, 2013

lsmith77 commented Jan 4, 2013

lsmith77 commented Jan 4, 2013

dbu commented Jan 9, 2013

adou600 commented Jan 10, 2013

lsmith77 commented Jan 10, 2013

lsmith77 Mar 7, 2013

Choose a reason for hiding this comment

adou600 Mar 9, 2013

Choose a reason for hiding this comment

lsmith77 Mar 9, 2013

Choose a reason for hiding this comment

adou600 commented Mar 9, 2013

dbu commented Mar 9, 2013

dbu commented Mar 18, 2013

adou600 commented Mar 22, 2013

dbu commented Mar 22, 2013

adou600 commented Mar 22, 2013

lsmith77 commented Mar 22, 2013

dbu commented Apr 18, 2013