Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use BinaryIO not TextIO in start_io() #497

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: use BinaryIO not TextIO in start_io() #497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pygls/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import sys
from concurrent.futures import ThreadPoolExecutor
from threading import Event
from typing import Any, Callable, Optional, TextIO, Type, TypeVar, Union
from typing import Any, BinaryIO, Callable, Optional, Type, TypeVar, Union

import cattrs
from pygls import IS_PYODIDE
Expand Down Expand Up @@ -231,7 +231,9 @@ def report_server_error(self, error: Exception, source: ServerErrors):
"""Default error reporter."""
logger.error("%s", error)

def start_io(self, stdin: Optional[TextIO] = None, stdout: Optional[TextIO] = None):
def start_io(
self, stdin: Optional[BinaryIO] = None, stdout: Optional[BinaryIO] = None
):
"""Starts IO server."""
logger.info("Starting IO server")

Expand Down
Loading