Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use BinaryIO not TextIO in start_io() #497

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

tombh
Copy link
Collaborator

@tombh tombh commented Sep 14, 2024

Although this is strictly an API change, I think it's actually just a fix because passing an actual TextIO object causes an error.

Fixes: #496

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

Automated linters

You can run the lints that are run on CI locally with:

poetry install --all-extras --with dev
poetry run poe lint

Although this is strictly an API change, I think it's actually just a
fix because passing an actual `TextIO` object causes an error.

Fixes: #496
@tombh tombh force-pushed the tombh/server-start-arg-type branch from 738c9d9 to ffa29f5 Compare September 14, 2024 13:57
@tombh tombh requested a review from alcarney September 16, 2024 13:08
@tombh tombh merged commit 0b2d5b9 into main Sep 17, 2024
16 checks passed
@tombh tombh deleted the tombh/server-start-arg-type branch September 17, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type on server.start_io
2 participants