Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: allow installation with typeguard 4.x #405

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Oct 28, 2023

Description

Bumps upper bound for typeguard from 4.0 to 5.0 allowing installation of typeguard 4.x
Bumps the locked version to 4.1.2
Tested locally with typeguard 4.1.5
Allows installation with typeguard 3.x still

Typeguard 4.0 was released back in May and this bound is blocking dependency resolution in other projects e.g. astral-sh/ruff-lsp#299

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

@zanieb zanieb changed the title Allow installation with typeguard 4.x build: allow installation with typeguard 4.x Oct 28, 2023
poetry.lock Show resolved Hide resolved
@tombh
Copy link
Collaborator

tombh commented Oct 28, 2023

Thank you ✨

@tombh tombh merged commit b10fc47 into openlawlibrary:main Oct 28, 2023
17 checks passed
@zanieb
Copy link
Contributor Author

zanieb commented Oct 28, 2023

Thank you! Would you mind publishing a release for this too?

@tombh tombh mentioned this pull request Oct 28, 2023
@tombh
Copy link
Collaborator

tombh commented Oct 28, 2023

Sure! https://pypi.org/project/pygls/1.1.2 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants