Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add default serviceName for asts #51

Merged
merged 1 commit into from
Apr 19, 2023
Merged

feat: add default serviceName for asts #51

merged 1 commit into from
Apr 19, 2023

Conversation

chrisliu1995
Copy link
Member

@chrisliu1995 chrisliu1995 commented Apr 12, 2023 •
edited
Loading

Background:

#50

@kruise-bot kruise-bot requested review from FillZpp and furykerry April 12, 2023 07:26
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ringtail
Copy link
Member

/LGTM

@ringtail ringtail merged commit ba8ce6c into openkruise:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FillZpp FillZpp Awaiting requested review from FillZpp

@furykerry furykerry Awaiting requested review from furykerry

Assignees

@ringtail ringtail

Labels
lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisliu1995 @kruise-bot @ringtail