Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serviceName support to GameServerSet for individual Pod DNS resolution #50

Closed
AisenQinjia opened this issue Apr 12, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@AisenQinjia
Copy link

AisenQinjia commented Apr 12, 2023

Hello,

I've been working with the OpenKruise Game project, specifically with the GameServerSet custom resource. I noticed that when using GameServerSet, the generated Pods do not have individual DNS records, which seems to be due to the missing subdomain field in the Pods' spec part.

In contrast, when using a StatefulSet with a specified serviceName, the Pods have a subdomain field, which allows for individual DNS resolution for each Pod.

To improve the functionality of GameServerSet, I would like to suggest adding support for a serviceName-like field or directly using the subdomain field. This would enable individual DNS resolution for each Pod managed by a GameServerSet, making it more convenient for use cases that require addressing individual Pods.

Please let me know if this is something that can be considered for implementation in the OpenKruise Game project or if there are any workarounds available to achieve this functionality.

@chrisliu1995 chrisliu1995 added the enhancement New feature or request label Apr 12, 2023
@chrisliu1995
Copy link
Member

OKG intends to simplify non-game-related concept fields, so it is planned not to add a serviceName field to users on GameServerSet. However, after the user define GameServerSet, the serviceName with the same name as GameServerSet will be used by default. Is this approach acceptable?

@AisenQinjia
Copy link
Author

OKG intends to simplify non-game-related concept fields, so it is planned not to add a serviceName field to users on GameServerSet. However, after the user define GameServerSet, the serviceName with the same name as GameServerSet will be used by default. Is this approach acceptable?

that would be nice, we are using StatefulSet in the same manner as you said above.

@ringtail
Copy link
Member

@AisenQinjia pr has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants