Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor User selection in group editing #811

Merged
merged 6 commits into from
May 11, 2022
Merged

Refactor User selection in group editing #811

merged 6 commits into from
May 11, 2022

Conversation

daniel-arnauer
Copy link
Contributor

@daniel-arnauer daniel-arnauer commented Apr 13, 2021 •
edited
Loading

Currently, only one user is can be sent to add or remove a user from a group. For better performance, send an array of user ids to the API

  • Refactor Postman collection json
  • Refactor Unit tests in API
  • Refactor UI
  • Refactor provisioning

Closes #725

@daniel-arnauer daniel-arnauer mentioned this pull request Apr 13, 2021
Closed
1 task
@daniel-arnauer daniel-arnauer self-assigned this Apr 13, 2021
@openkfwCI
Copy link

openkfwCI commented Apr 13, 2021 •
edited
Loading

NotesTime
❌Note for Reviewer: E2E tests on remote server failedWed, 11 May 2022 13:27:08 +0000

Generated by E2E-Test

@daniel-arnauer daniel-arnauer force-pushed the 725-better-user-group-edit branch 4 times, most recently from 34c6147 to 15b1c44 Compare April 20, 2021 11:15
@daniel-arnauer daniel-arnauer removed their assignment Apr 20, 2021
@Stezido
Copy link
Contributor

Stezido commented Jun 8, 2021

Closing PR - other focus (RoadMap)

@Stezido Stezido closed this Jun 8, 2021
@mayrmartin mayrmartin added the api Indicates api related issue or feature label Jul 5, 2021
@mayrmartin mayrmartin added this to the TruBudget 2.0.0 milestone Jul 5, 2021
@Stezido Stezido removed this from the TruBudget 2.0.0 milestone Jul 13, 2021
@daniel-arnauer daniel-arnauer force-pushed the 725-better-user-group-edit branch 2 times, most recently from c3c7c8e to 765779c Compare April 11, 2022 14:15
@daniel-arnauer daniel-arnauer changed the base branch from master to new-2.0.0 April 11, 2022 14:26
@daniel-arnauer daniel-arnauer changed the title Refactor User selection in group editing Draft: Refactor User selection in group editing Apr 11, 2022
@Stezido Stezido changed the base branch from new-2.0.0 to 2.0.0-release April 13, 2022 08:41
@daniel-arnauer daniel-arnauer force-pushed the 725-better-user-group-edit branch from 765779c to 37aebd1 Compare April 25, 2022 14:24
@daniel-arnauer daniel-arnauer changed the title Draft: Refactor User selection in group editing Refactor User selection in group editing Apr 25, 2022
@daniel-arnauer daniel-arnauer force-pushed the 725-better-user-group-edit branch from 37aebd1 to 3bddb48 Compare April 26, 2022 07:59
@daniel-arnauer daniel-arnauer force-pushed the 725-better-user-group-edit branch from 3bddb48 to 6ca9e8b Compare May 3, 2022 14:48
@github-actions
Copy link

github-actions bot commented May 3, 2022 •
edited
Loading

Warnings
⚠️ It looks like an ID was added. Please make sure it is not a secret.

Generated by 🚫 dangerJS against dde5eaf

@daniel-arnauer daniel-arnauer force-pushed the 725-better-user-group-edit branch from 967eff3 to c2c4ab4 Compare May 10, 2022 08:40
@mayrmartin mayrmartin self-requested a review May 10, 2022 09:38
mayrmartin
mayrmartin requested changes May 10, 2022
View reviewed changes
Copy link
Collaborator

@mayrmartin mayrmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since endpoints changed pls update load-test endpoints (can be generated via API specification)

api/src/service/domain/organization/group_eventsourcing.ts Outdated Show resolved Hide resolved
api/src/service/domain/organization/group_eventsourcing.ts Outdated Show resolved Hide resolved
@daniel-arnauer daniel-arnauer force-pushed the 725-better-user-group-edit branch from fe5c445 to d183a36 Compare May 11, 2022 07:09
@mayrmartin mayrmartin self-requested a review May 11, 2022 07:21
@daniel-arnauer daniel-arnauer force-pushed the 725-better-user-group-edit branch from d183a36 to dde5eaf Compare May 11, 2022 12:45
@daniel-arnauer daniel-arnauer merged commit ad3061f into 2.0.0-release May 11, 2022
@daniel-arnauer daniel-arnauer deleted the 725-better-user-group-edit branch May 11, 2022 13:32
@daniel-arnauer daniel-arnauer mentioned this pull request May 12, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayrmartin mayrmartin mayrmartin approved these changes

Assignees

@daniel-arnauer daniel-arnauer

Labels
api Indicates api related issue or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User selection in group editing has an api call for each selection - SP 0.5
4 participants
@daniel-arnauer @openkfwCI @Stezido @mayrmartin