Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User selection in group editing has an api call for each selection - SP 0.5 #725

Closed
2 tasks done
georgimld opened this issue Jan 13, 2021 · 4 comments · Fixed by #811
Closed
2 tasks done

User selection in group editing has an api call for each selection - SP 0.5 #725

georgimld opened this issue Jan 13, 2021 · 4 comments · Fixed by #811
Assignees
Labels
api Indicates api related issue or feature frontend Indicates frontend related issue or feature

Comments

@georgimld
Copy link
Collaborator

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Each time a user is selected or deselected using the checkbox in the dialog, an api call for group.addUser or group.removeUser is bein sent.

Expected Behavior 🤔

Users to be added and removed should be stored (e.g. in an array), and the requests should only be sent when clicking the "Done" button.

Steps to Reproduce 🕹

Steps:

  1. open the edit dialog of a group
  2. click on the dropdown for selecting users
  3. try to select or deselect users and look at what calls are being sent

Your Environment 🌎

Tech Version
TruBudget v1.17.0
@SamuelPull SamuelPull assigned SamuelPull and unassigned SamuelPull Jan 18, 2021
@Stezido Stezido added this to the Trubudget 1.19.0 milestone Jan 20, 2021
@galethil galethil changed the title User selection in group editing has an api call for each selection User selection in group editing has an api call for each selection - 8SP Jan 20, 2021
@mayrmartin mayrmartin added the api Indicates api related issue or feature label Jul 5, 2021
@stale
Copy link

stale bot commented Aug 4, 2021

This issue has been automatically marked as stale because it has not had activity for 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 4, 2021
@stale stale bot closed this as completed Aug 11, 2021
@Stezido Stezido reopened this Mar 24, 2022
@stale stale bot removed the wontfix This will not be worked on label Mar 24, 2022
@stale
Copy link

stale bot commented Apr 23, 2022

This issue has been automatically marked as stale because it has not had activity for 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 23, 2022
@stale
Copy link

stale bot commented Apr 30, 2022

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Apr 30, 2022
@Stezido Stezido reopened this May 3, 2022
@stale stale bot removed the wontfix This will not be worked on label May 3, 2022
@Stezido Stezido changed the title User selection in group editing has an api call for each selection - 8SP User selection in group editing has an api call for each selection - SP 0.5 May 9, 2022
@issuelabeler issuelabeler bot added the frontend Indicates frontend related issue or feature label May 9, 2022
@daniel-arnauer
Copy link
Contributor

Closed by #811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Indicates api related issue or feature frontend Indicates frontend related issue or feature
Projects
None yet
5 participants