Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Governance changes for Collaboration Network #547

Merged
merged 11 commits into from
Oct 20, 2020

Conversation

mhdawson
Copy link
Member

Governance changes to be landed once the Collaboration
network proposal reaches stage 3.

Signed-off-by: Michael Dawson [email protected]

Governance changes to be landed once the Collaboration
network proposal reaches stage 3.

Signed-off-by: Michael Dawson <[email protected]>
@mhdawson mhdawson changed the title doc: Goveranance changes for Collaboration Network WIP doc: Goveranance changes for Collaboration Network May 13, 2020
Copy link
Member

@joesepi joesepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

@kborchers kborchers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of minor typo comments but otherwise this LGTM

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some notes, need to review the collaboration network proposal to get more details

As this changes the charter it will need board approval.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
CPC-CHARTER.md Outdated Show resolved Hide resolved
@tobie tobie changed the title doc: Goveranance changes for Collaboration Network doc: Governance changes for Collaboration Network Jul 28, 2020
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
CPC-CHARTER.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally LGTM

@MylesBorins
Copy link
Contributor

We could likely split out the README changes into another PR that doesn't require board approval... but keeping it in the single PR and only sending the charter changes to the board seems simple enough

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
CPC-CHARTER.md Outdated Show resolved Hide resolved
CPC-CHARTER.md Outdated Show resolved Hide resolved
@mhdawson
Copy link
Member Author

mhdawson commented Sep 8, 2020

@darcyclarke thanks for the review, think I have addressed your comments.

Copy link
Contributor

@tobie tobie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member Author

PR Landed, so closing

@mhdawson mhdawson closed this Oct 13, 2020
@mhdawson
Copy link
Member Author

oops reopening, should have landed

@mhdawson mhdawson reopened this Oct 20, 2020
@mhdawson mhdawson merged commit 72b768e into openjs-foundation:master Oct 20, 2020
tobie pushed a commit that referenced this pull request Sep 1, 2023
* doc: Goveranance changes for Collaboration Network

Governance changes to be landed once the Collaboration
network proposal reaches stage 3.

Signed-off-by: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.