-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Pybehave: a hardware-agnostic, Python-based framework for developing behavioral neuroscience experiments #6515
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
Hello again! 👋 FYI @theonlydvr This is the review thread for the paper. All of our higher-level communications will happen here from now on, review comments and discussion can happen in the repository of the project (details below). 📓 Please read the "Reviewer instructions & questions" in the comment from our editorialbot (above). ✅ All reviewers get their own checklist with the JOSS requirements - you generate them as per the details in the editorialbot comment. As you go over the submission, please check any items that you feel have been satisfied. 💻 The JOSS review is different from most other journals: The reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention the link to #6515 so that a link is created to this thread. That will also help me to keep track! ❓ Please also feel free to comment and ask questions on this thread if you are unsure about something! 🎯 We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. |
Review checklist for @alustig3Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @tuliofalmeidaConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @tuliofalmeida @alustig3 -- just to check in with you: What are your respective timelines for completing the present review? Are there any blockers that I can help remove? |
@tuliofalmeida I see that you have nearly completed your review, thanks for that. Please let me know if there are any questions that I can help with in the meantime. Once you have fully completed your review, I'd appreciate if you could post your final "verdict" as a comment in this thread. @alustig3 I have reached out to you via email, using the email you provide on your website -- hoping to hear from you soon! |
@sappelhoff I am making progress and aim to finish within a week. |
@alustig3 @tuliofalmeida could I get a brief status update of your reviews, please? @theonlydvr could you provide an update from your side as well, please? Are there any questions about the review process, or anything we should discuss/clarify? |
I'm finishing! The authors made the updates in the package (very quickly) but I didn't had time to check it yet. I'm planning to finish this week. |
Review process has been going well! Feedback has been very helpful and useful for addressing some of the weak points in the documentation and setup process. |
@sappelhoff I have completed my review checklist. @theonlydvr is addressing a few remaining GitHub issues and pull requests that I created. |
Hey @sappelhoff I finished my part of the review. The idea was to test it with a lab friend that do experiments but doesn't code. @theonlydvr did a good job, my main point is to improve the documentation and tutorial for people that are not comfortable with coding and he's doing it. |
Thanks for the note @tuliofalmeida! @alustig3 @tuliofalmeida, I can see you both checked your reviewer lists fully. I'd appreciate it, if you could briefly make a statement whether you would recommend this paper for publication, or whether there are items that need to be dealt with before. For example, in @alustig3's reviewer list, I see some linked PRs/issues that have not yet been merged/closed, and @tuliofalmeida mentions:
... which suggest to me, that there are still some things to be done. In any way, thanks already for the work until here, it seems like we are nearing the completion of this review process. |
All of @alustig3's remaining issues/PRs should now be addressed |
Thanks @theonlydvr. And thanks a lot @tuliofalmeida and @alustig3 for your reviews. 🚀 Maybe I am being pedantic, but I would like to see your explicit recommendation to publish this paper. Something along the lines: "I recommend this paper for publication". If I don't hear back within one week, I will go ahead and take your previous comments and your respectively finished reviewers lists as implicit recommendation for publication, and will start with the final steps. |
I recommend this paper for publication |
@theonlydvr as AEiC for JOSS I will now help to process this submission for acceptance in JOSS. I have checked this review, your repository, the archive link, and the paper. I only have the below point that requires your attention:
|
The spelling should be updated with the latest commit |
@editorialbot generate pdf |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Awesome! Everything looks good except it seems like my last name "Dastin-van Rijn" autogenerated to only have "Rijn" as the last name in the citation metadata. I've corrected this in the CITATION.cff in the original repository but I assume this has no effect on the actual merged paper. Apologies for the space in the last name... |
Thanks for letting us know @theonlydvr -- That's probably a task for an AEIC to sort out, as my influence on these things is limited. Is that correct @Kevin-Mattheus-Moerman? |
@sappelhoff @theonlydvr yes we can take it from here. I'll ping @openjournals/dev to see if they can offer some guidance on this one. |
The parts of the name can be described with more precision in the paper's metadata: Updating the paper.md file and then reaccepting should update the published strings. |
Thank you! I think I've fixed it with the latest commit (I just replaced the name with an explicit given and surname). |
@editorialbot reaccept |
|
🌈 Paper updated! New PDF and metadata files 👉 openjournals/joss-papers#5462 |
@theonlydvr Are you happy with the update? |
Looks great! Thank you! |
@theonlydvr congratulations on this JOSS publication! @sappelhoff thanks for editing! And a special thank you to the reviewers: @tuliofalmeida, @alustig3 !! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @theonlydvr (Evan Dastin-van Rijn)
Repository: https://github.com/tne-lab/py-behav-box-v2
Branch with paper.md (empty if default branch):
Version: v1.0.19
Editor: @sappelhoff
Reviewers: @tuliofalmeida, @alustig3
Archive: 10.5281/zenodo.11244351
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@tuliofalmeida & @alustig3, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @sappelhoff know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @alustig3
📝 Checklist for @tuliofalmeida
The text was updated successfully, but these errors were encountered: