Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: ipcc - a Python package for the calculation of national greenhouse gas inventories #6123

Closed
editorialbot opened this issue Dec 5, 2023 · 80 comments
Assignees
Labels
accepted published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review TeX Track: 3 (PE) Physics and Engineering

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Dec 5, 2023

Submitting author: @mabudz (Maik Budzinski)
Repository: https://gitlab.com/bonsamurais/bonsai/util/ipcc
Branch with paper.md (empty if default branch): joss
Version: v0.3.2
Editor: @pdebuyl
Reviewers: @GISWLH, @PennyHow
Archive: 10.5281/zenodo.10822520

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d193aff8fe402e6fa597d7dc1b0538f6"><img src="https://joss.theoj.org/papers/d193aff8fe402e6fa597d7dc1b0538f6/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d193aff8fe402e6fa597d7dc1b0538f6/status.svg)](https://joss.theoj.org/papers/d193aff8fe402e6fa597d7dc1b0538f6)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@GISWLH & @PennyHow, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @pdebuyl know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @PennyHow

📝 Checklist for @GISWLH

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.14 s (443.9 files/s, 157705.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
YAML                             4             26             39           7975
Python                          40           1806           2976           6355
Markdown                        13            163              0            506
Jupyter Notebook                 3              0           2461            230
INI                              1             11              0             81
TeX                              1              5              0             63
make                             1              6              8             15
TOML                             1              1              3              5
-------------------------------------------------------------------------------
SUM:                            64           2018           5487          15230
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1504

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/jiec.12713 is OK
- 10.1111/jiec.12715 is OK
- 10.1080/07350015.2015.1038545 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@PennyHow
Copy link

PennyHow commented Dec 5, 2023

Review checklist for @PennyHow

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://gitlab.com/bonsamurais/bonsai/util/ipcc?
  • License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@mabudz) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@GISWLH
Copy link

GISWLH commented Dec 5, 2023

Review checklist for @GISWLH

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://gitlab.com/bonsamurais/bonsai/util/ipcc?
  • License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@mabudz) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@pdebuyl
Copy link

pdebuyl commented Dec 5, 2023

@GISWLH @PennyHow please check the information text at the top of this page (@PennyHow I see this is already done, thanks for starting!).

As the review takes place into this discussion page, feel free to provide a partial review at some point, to ask clarifications to the author here, or to ask me about the review process.

Some reviewers also open issues at the repository under review. This is fine for bug reports or requests about the documentation, for instance. In that case, please report the resulting bugfix or other result from the discussion here so that I can get proper notification.

@GISWLH
Copy link

GISWLH commented Dec 5, 2023

Thank you, @pdebuyl, for your invitation and kind reminder 👋. I will review this paper and its code in the coming days. I guess i will raising issues in the ipcc repository. Once completed, a summary of my observations will also be provided here.

@pdebuyl
Copy link

pdebuyl commented Dec 5, 2023

Hi @GISWLH I see that you ticked all the boxes already. Their purpose is to indicate the progress of your review, which I guess is not yet over. Can you untick them please?

@GISWLH
Copy link

GISWLH commented Dec 5, 2023

Sorry for the misunderstanding and i have now unticked the option. @pdebuyl

@PennyHow
Copy link

PennyHow commented Dec 15, 2023

Hi @mabudz and @pdebuyl, here is my initial review: in all, I think this is a useful package that upholds the idea of reproducibility and accessibility to an important set of IPCC data and calculations. I have some comments on how it is presented and distributed that need to be resolved before it should be accepted from my side:

  • The JOSS paper itself looks in good shape. I've made some minor corrections in a merge request here, along with suggested changes to the repo readme and documentation.

  • I see you note in the readme that the pypi package distribution is not ready yet. I would like to see the pypi package finalised (and usable) as part of this review process.

  • On a related note to the point above, can the example scripts also be distributed with the pypi package build? I would like to see the example included and incorporated into the testing of the package installation, perhaps as part of some unit testing for the package. I also see a tests/ directory with many scripts - do you use these in your examples in the documentation and/or the package distribution?

  • There are many tutorials in your documentation that merely perform look-ups from the .csv tables. I would like to see more tutorials in the documentation that demonstrate the functionality of the ipcc package, such as calculating GHG inventories and inter-comparison of the different uncertainty calculation methods. Without these examples, it is difficult to see the capabilities of the package beyond just a library of look-up tables.

  • The contributions section thoroughly describes where a contributor could contribute to the ipcc package. However, there is little description on how a contributor should contribute (e.g. merge request from a forked branch, with a clear description of the contributions?). Please outline this in the CONTRIBUTING.md file.

  • Please specify somewhere in the installation guide that the ipcc package requires python>=3.9. In fact, I think it would be good to include a complete installation guide, so something like this:

conda create --name py311 python=3.11
conda activate py311
git clone [email protected]:bonsamurais/bonsai/util/ipcc.git
cd ipcc
pip install -e .
python3
import ipcc

@GISWLH
Copy link

GISWLH commented Dec 18, 2023

Dear @pdebuyl and @mabudz, this is my review report:
In my opinion, this package provides tools for national greenhouse gas calculation and takes into account uncertainty from IPCC guidelines. It holds potential applicative value for climate change scientists and aligns with the interests and scope of the JOSS journal. However, I have the following suggestions for its improvement:

  • I am uncertain about the appropriateness of the author's use of the organizational function format ipcc.<volume>.<chapter>. With the release of new versions of the IPCC reports, the names of volumes and chapters may change.
  • The authors should provide more background information in the repository. It should include PDFs of some IPCC chapters (e.g., https://www.ipcc.ch/site/assets/uploads/2018/03/5_Waste-1.pdf), as these contain the original formulas for users to verify.
  • I wonder if it's appropriate for the author to use ipcc as the name for a Python library, given that IPCC is a non-profit organization dedicated to climate change science, encompassing not just greenhouse gas calculations but also climate change, regional imbalances, emission scenarios, hydrology, and water cycles, among other topics. Considering the actual functionality of the author's library, a name like ipccgas might be more suitable. Of course, this is just a suggestion for the author to consider, as the library is their development.
  • The current version may not be sufficiently user-friendly, as users might not know how to apply their data for uncertainty analysis. I didn't find adequate guidance on how to apply my data. The authors should clearly provide specific steps or a simple example.
  • Some parts of the README code cannot be executed directly. The author should carefully check to avoid errors. For example, in the 'Add own data' section, swd.parameter.r = df should be corrected to my_ipcc.waste.swd.parameter.r = df.

@mabudz
Copy link

mabudz commented Dec 20, 2023

Dear @PennyHow, @GISWLH and @pdebuyl ,
thanks a lot for the excellent comments!

I have revised the package and merged already to the main branch (The manuscript is still on the joss branch).
The following has been changed:

  • The package is available on PyPi as bonsai-ipcc. Regarding the suggestion for changing the name, I think this also avoids confusion in terms of the official IPCC organization. However, the package name is still ipcc.
  • I revised the tutorials. The previous versions, indeed, had a lot of dataframe manipulation which made it difficult to identify the main functionalities. By restructuring the jupyter tutorials into basic concept, core functionality and uncertainty I hope this is more obvious, especially in terms of adding own data with uncertainty information. I also deleted the folder scripts/ which was not intended to be in the package.
  • The readme.md has been revised to provide a full working example. Furthermore, I added additional information linking to the pdf documents of the IPCC guidelines.
  • The contributing.md has been revised to provide more detailed instructions (e.g., create issue, create branch, merge request etc). Also regarding the required python version >=3.9

I still think that following the structure of volume and chapter makes sense. The reason is that this should help users to find the specific information about equations, tier sequences and data also in the original pdf documents. The IPCC guidelines were published in 2006 and got and update in 2019 without changing the original structure of volume and sequence. For further updates I hope they follow the same logic.

@pdebuyl
Copy link

pdebuyl commented Dec 22, 2023

Thanks @PennyHow @GISWLH for the reviews and recommendations!

Regarding the distribution of examples with the software package, it is not a widespread practice so I don't believe that it can be essential as a review item. @mabudz you are free to take it into account of course. @PennyHow do you have examples of how you would see this achieved?

Regarding the package name, it could be indeed beneficial to the package to avoid any confusion. bonsai_ipcc woud fit the PyPI name (bonsai-ipcc cannot be imported).

I have a remark on the README part on installing the package. Only developers should install with the -e option to pip -> else the package is at risk of being modified in place thus modifying the results of the calculations.

@mabudz
Copy link

mabudz commented Jan 4, 2024

Thanks @pdebuyl,
The pypi name is indeed bonsai_ipcc.

The readme has now two separate instructions for users and developers. Only for developers pip install -e is recommended.

@PennyHow
Copy link

PennyHow commented Jan 8, 2024

Regarding the distribution of examples with the software package, it is not a widespread practice so I don't believe that it can be essential as a review item. @mabudz you are free to take it into account of course. @PennyHow do you have examples of how you would see this achieved?

I think with the newly updated examples in the documentation, they do not need to be included with the package distribution.

Regarding the package name, it could be indeed beneficial to the package to avoid any confusion. bonsai_ipcc woud fit the PyPI name (bonsai-ipcc cannot be imported).

I agree with this. To install, the pypi distribution is named bonsai-ipcc (i.e. install as pip install bonsai-ipcc). But to import, the package name remains ipcc (i.e. import ipcc). I think the import name should also be bonsai-ipcc to avoid potential conflicts with other packages.

All the other comments from me have been adequately addressed.

@mabudz
Copy link

mabudz commented Jan 15, 2024

I have changed the package name. To avoid conflicts bonsai_ipcc is used for both the package name and the name on pypi. I have revised the manuscript in this regard.

@mabudz
Copy link

mabudz commented Jan 15, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@mabudz
Copy link

mabudz commented Jan 22, 2024

Dear @pdebuyl , @PennyHow , @GISWLH ,

Many thanks for your recommendations, I have tried to address all of those. Please let me know if you have any further recommendations.

@PennyHow
Copy link

Many thanks for your recommendations, I have tried to address all of those. Please let me know if you have any further recommendations.

Nothing else from me. You have adequately addressed all of my comments 👍🏼

@GISWLH
Copy link

GISWLH commented Jan 23, 2024

Many thanks for your recommendations, I have tried to address all of those. Please let me know if you have any further recommendations.

Upon reviewing the revisions you've implemented based on my recommendations, I am pleased to endorse this manuscript for publication.

@pdebuyl
Copy link

pdebuyl commented Feb 21, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/jiec.12713 is OK
- 10.1111/jiec.12715 is OK
- 10.1080/07350015.2015.1038545 is OK
- 10.1038/s41586-020-2649-2 is OK

MISSING DOIs

- No DOI given, and none found for title: 2019 Refinement to the 2006 IPCC Guidelines for Na...
- No DOI given, and none found for title: The Big Climate Database v1 – Methodology report
- No DOI given, and none found for title: ecoinvent report no. 15 - Life Cycle Inventories o...
- No DOI given, and none found for title: Hestia Engine Models
- No DOI given, and none found for title: uncertainties
- No DOI given, and none found for title: pandas: a Foundational Python Library for Data Ana...
- No DOI given, and none found for title: Data Software and Standards
- No DOI given, and none found for title: frictionless-py

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

⚠️ Error preparing paper acceptance. The generated XML metadata file is invalid.

Element isbn: [facet 'minLength'] The value has a length of '9'; this underruns the allowed minimum length of '10'.

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/jiec.12713 is OK
- 10.1111/jiec.12715 is OK
- 10.1080/07350015.2015.1038545 is OK
- 10.1038/s41586-020-2649-2 is OK

MISSING DOIs

- No DOI given, and none found for title: 2019 Refinement to the 2006 IPCC Guidelines for Na...
- No DOI given, and none found for title: The Big Climate Database v1 – Methodology report
- No DOI given, and none found for title: ecoinvent report no. 15 - Life Cycle Inventories o...
- Errored finding suggestions for "Hestia Engine Models", please try later
- No DOI given, and none found for title: uncertainties
- No DOI given, and none found for title: pandas: a Foundational Python Library for Data Ana...
- No DOI given, and none found for title: Data Software and Standards
- No DOI given, and none found for title: frictionless-py

INVALID DOIs

- None

@pdebuyl
Copy link

pdebuyl commented Mar 22, 2024

Also: for pandas citation please use their recommendation: https://pandas.pydata.org/about/citing.html

@InProceedings{ mckinney-proc-scipy-2010,
  author    = { {W}es {M}c{K}inney },
  title     = { {D}ata {S}tructures for {S}tatistical {C}omputing in {P}ython },
  booktitle = { {P}roceedings of the 9th {P}ython in {S}cience {C}onference },
  pages     = { 56 - 61 },
  year      = { 2010 },
  editor    = { {S}t\'efan van der {W}alt and {J}arrod {M}illman },
  doi       = { 10.25080/Majora-92bf1922-00a }
}

@pdebuyl
Copy link

pdebuyl commented Mar 22, 2024

Regarding the automated error: citation item numpy should not have a isbn at all as it is not a book. The entry is actually the ISSN of Nature but it is not mandatory to use that.

@mabudz
Copy link

mabudz commented Mar 22, 2024

Thanks @pdebuyl ,
I have revised the references for pandas and numpy.

No orcid for Mathieu Delpierre. It is fine to proceed without orcid.

@pdebuyl
Copy link

pdebuyl commented Mar 22, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@pdebuyl
Copy link

pdebuyl commented Mar 22, 2024

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/jiec.12713 is OK
- 10.1111/jiec.12715 is OK
- 10.1080/07350015.2015.1038545 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.25080/Majora-92bf1922-00a is OK

MISSING DOIs

- No DOI given, and none found for title: 2019 Refinement to the 2006 IPCC Guidelines for Na...
- No DOI given, and none found for title: The Big Climate Database v1 – Methodology report
- No DOI given, and none found for title: ecoinvent report no. 15 - Life Cycle Inventories o...
- No DOI given, and none found for title: Hestia Engine Models
- No DOI given, and none found for title: uncertainties
- No DOI given, and none found for title: Data Software and Standards
- No DOI given, and none found for title: frictionless-py

INVALID DOIs

- None

@pdebuyl
Copy link

pdebuyl commented Mar 22, 2024

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/jiec.12713 is OK
- 10.1111/jiec.12715 is OK
- 10.1080/07350015.2015.1038545 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.25080/Majora-92bf1922-00a is OK

MISSING DOIs

- No DOI given, and none found for title: 2019 Refinement to the 2006 IPCC Guidelines for Na...
- No DOI given, and none found for title: The Big Climate Database v1 – Methodology report
- No DOI given, and none found for title: ecoinvent report no. 15 - Life Cycle Inventories o...
- No DOI given, and none found for title: Hestia Engine Models
- No DOI given, and none found for title: uncertainties
- No DOI given, and none found for title: Data Software and Standards
- No DOI given, and none found for title: frictionless-py

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/pe-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5165, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@editorialbot editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Mar 22, 2024
@pdebuyl
Copy link

pdebuyl commented Mar 22, 2024

Thanks @mabudz for the submission, @PennyHow and @GISWLH for reviewing!

@kyleniemeyer
Copy link

@editorialbot accept

@editorialbot
Copy link
Collaborator Author

Doing it live! Attempting automated processing of paper acceptance...

@editorialbot
Copy link
Collaborator Author

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- family-names: Budzinski
  given-names: Maik
  orcid: "https://orcid.org/0000-0003-2879-1193"
- family-names: Rodrigues
  given-names: Joao F. D.
  orcid: "https://orcid.org/0000-0002-1437-0059"
- family-names: Delpierre
  given-names: Mathieu
doi: 10.5281/zenodo.10822520
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - family-names: Budzinski
    given-names: Maik
    orcid: "https://orcid.org/0000-0003-2879-1193"
  - family-names: Rodrigues
    given-names: Joao F. D.
    orcid: "https://orcid.org/0000-0002-1437-0059"
  - family-names: Delpierre
    given-names: Mathieu
  date-published: 2024-03-26
  doi: 10.21105/joss.06123
  issn: 2475-9066
  issue: 95
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 6123
  title: bonsai_ipcc - a Python package for the calculation of national
    greenhouse gas inventories
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.06123"
  volume: 9
title: bonsai_ipcc - a Python package for the calculation of national
  greenhouse gas inventories

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

@editorialbot
Copy link
Collaborator Author

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

@editorialbot
Copy link
Collaborator Author

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.06123 joss-papers#5176
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06123
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@editorialbot editorialbot added accepted published Papers published in JOSS labels Mar 26, 2024
@kyleniemeyer
Copy link

Congratulations @mabudz on your article's publication in JOSS! Please consider signing up as a reviewer if you haven't already.

Many thanks to @GISWLH and @PennyHow for reviewing this, and @pdebuyl for editing.

@editorialbot
Copy link
Collaborator Author

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06123/status.svg)](https://doi.org/10.21105/joss.06123)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06123">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06123/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06123/status.svg
   :target: https://doi.org/10.21105/joss.06123

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review TeX Track: 3 (PE) Physics and Engineering
Projects
None yet
Development

No branches or pull requests

6 participants