-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: ipcc - a Python package for the calculation of national greenhouse gas inventories #6123
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @PennyHowConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @GISWLHConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@GISWLH @PennyHow please check the information text at the top of this page (@PennyHow I see this is already done, thanks for starting!). As the review takes place into this discussion page, feel free to provide a partial review at some point, to ask clarifications to the author here, or to ask me about the review process. Some reviewers also open issues at the repository under review. This is fine for bug reports or requests about the documentation, for instance. In that case, please report the resulting bugfix or other result from the discussion here so that I can get proper notification. |
Thank you, @pdebuyl, for your invitation and kind reminder 👋. I will review this paper and its code in the coming days. I guess i will raising issues in the ipcc repository. Once completed, a summary of my observations will also be provided here. |
Hi @GISWLH I see that you ticked all the boxes already. Their purpose is to indicate the progress of your review, which I guess is not yet over. Can you untick them please? |
Sorry for the misunderstanding and i have now unticked the option. @pdebuyl |
Hi @mabudz and @pdebuyl, here is my initial review: in all, I think this is a useful package that upholds the idea of reproducibility and accessibility to an important set of IPCC data and calculations. I have some comments on how it is presented and distributed that need to be resolved before it should be accepted from my side:
|
Dear @pdebuyl and @mabudz, this is my review report:
|
Dear @PennyHow, @GISWLH and @pdebuyl , I have revised the package and merged already to the main branch (The manuscript is still on the joss branch).
I still think that following the structure of |
Thanks @PennyHow @GISWLH for the reviews and recommendations! Regarding the distribution of examples with the software package, it is not a widespread practice so I don't believe that it can be essential as a review item. @mabudz you are free to take it into account of course. @PennyHow do you have examples of how you would see this achieved? Regarding the package name, it could be indeed beneficial to the package to avoid any confusion. I have a remark on the README part on installing the package. Only developers should install with the |
Thanks @pdebuyl, The readme has now two separate instructions for users and developers. Only for developers |
I think with the newly updated examples in the documentation, they do not need to be included with the package distribution.
I agree with this. To install, the pypi distribution is named All the other comments from me have been adequately addressed. |
I have changed the package name. To avoid conflicts |
@editorialbot generate pdf |
Nothing else from me. You have adequately addressed all of my comments 👍🏼 |
Upon reviewing the revisions you've implemented based on my recommendations, I am pleased to endorse this manuscript for publication. |
@editorialbot generate pdf |
|
Element isbn: [facet 'minLength'] The value has a length of '9'; this underruns the allowed minimum length of '10'. |
|
Also: for pandas citation please use their recommendation: https://pandas.pydata.org/about/citing.html
|
Regarding the automated error: citation item numpy should not have a isbn at all as it is not a book. The entry is actually the ISSN of Nature but it is not mandatory to use that. |
Thanks @pdebuyl , No orcid for Mathieu Delpierre. It is fine to proceed without orcid. |
@editorialbot generate pdf |
@editorialbot check references |
|
@editorialbot recommend-accept |
|
|
👋 @openjournals/pe-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5165, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations @mabudz on your article's publication in JOSS! Please consider signing up as a reviewer if you haven't already. Many thanks to @GISWLH and @PennyHow for reviewing this, and @pdebuyl for editing. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @mabudz (Maik Budzinski)
Repository: https://gitlab.com/bonsamurais/bonsai/util/ipcc
Branch with paper.md (empty if default branch): joss
Version: v0.3.2
Editor: @pdebuyl
Reviewers: @GISWLH, @PennyHow
Archive: 10.5281/zenodo.10822520
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@GISWLH & @PennyHow, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @pdebuyl know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @PennyHow
📝 Checklist for @GISWLH
The text was updated successfully, but these errors were encountered: