Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: geopolrisk-py: A Python-Based Library to Operationalize the Geopolitical Supply Risk Method for use in Life Cycle Assessment and Comparative Risk Assessment #7414

Closed
editorialbot opened this issue Oct 28, 2024 · 10 comments

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @akoyamp (Anish Koyamparambath)
Repository: https://github.com/akoyamp/geopolrisk-py/
Branch with paper.md (empty if default branch): main
Version: V2
Editor: Pending
Reviewers: Pending
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/153058b0b60090f95a6ca87636d826fe"><img src="https://joss.theoj.org/papers/153058b0b60090f95a6ca87636d826fe/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/153058b0b60090f95a6ca87636d826fe/status.svg)](https://joss.theoj.org/papers/153058b0b60090f95a6ca87636d826fe)

Author instructions

Thanks for submitting your paper to JOSS @akoyamp. Currently, there isn't a JOSS editor assigned to your paper.

@akoyamp if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.02 s (676.7 files/s, 179043.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           6             87            333            725
Markdown                         3            134              0            638
TeX                              1              0              0            215
Jupyter Notebook                 1              0            955             63
YAML                             1              2              4             19
-------------------------------------------------------------------------------
SUM:                            12            223           1292           1660
-------------------------------------------------------------------------------

Commit count by author:

   113	Anish Koyamparambath
    24	Thomas Schraml
    12	Anish KOYAMPARAMBATH

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1007/s11367-013-0670-5 is OK
- 10.1111/jiec.12865 is OK
- 10.1016/j.procir.2022.02.071 is OK
- 10.1007/s11367-022-02027-y is OK
- 10.21105/joss.00236 is OK
- 10.1016/j.resconrec.2023.106935 is OK
- 10.1016/j.resourpol.2021.102465 is OK
- 10.1016/j.jclepro.2015.01.082 is OK
- 10.1016/j.resconrec.2019.104617 is OK
- 10.1111/jiec.12279 is OK
- 10.1016/j.jclepro.2016.07.214 is OK
- 10.1007/s11367-016-1137-2 is OK
- 10.1016/j.resconrec.2024.107801 is OK
- 10.1016/j.resconrec.2020.105108 is OK
- 10.1007/s11367-020-01737-5 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: The Herfindahl-Hirschman index
- No DOI given, and none found for title: BACI: International Trade Database at the Product-...
- No DOI given, and none found for title: Federal ministry republic of Austria
- No DOI given, and none found for title: Worldwide Governance Indicators
- No DOI given, and none found for title: Critical evaluation of material criticality and pr...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1728

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

CLPFUDatabase: A suite of R packages for energy conversion chain analysis
Submitting author: @MatthewHeun
Handling editor: @timtroendle (Retired)
Reviewers: @abhishektiwari, @nmstreethran
Similarity score: 0.6660

bonsai_ipcc - a Python package for the calculation of national greenhouse gas inventories
Submitting author: @mabudz
Handling editor: @pdebuyl (Active)
Reviewers: @GISWLH, @PennyHow
Similarity score: 0.6638

GeoClimate: a Geospatial processing toolbox for environmental and climate studies
Submitting author: @ebocher
Handling editor: @elbeejay (Active)
Reviewers: @abhishekvp, @omshinde, @arbennett
Similarity score: 0.6545

pyCSEP: A Python Toolkit For Earthquake Forecast Developers
Submitting author: @wsavran
Handling editor: @kbarnhart (Retired)
Reviewers: @nvanderelst, @mbarall
Similarity score: 0.6476

Biotrade: A Python package to access and analyse the international trade of bio-based products
Submitting author: @paulrougieux
Handling editor: @martinfleis (Active)
Reviewers: @FATelarico, @potterzot
Similarity score: 0.6448

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@arfon
Copy link
Member

arfon commented Oct 28, 2024

@akoyamp – thanks for your submission to JOSS. Unfortunately this submission is not eligible to be published in JOSS in its current form. As per our submission requirements:

In addition, JOSS requires that software should be feature-complete (i.e., no half-baked solutions), packaged appropriately according to common community standards for the programming language being used (e.g., Python, R).

This Python code should be packaged according to common Python community conventions. Additionally, there do not seem to be any testing procedures for this code which also means it would fail a JOSS review.

Finally, I note that the scholarly contribution of this submission looks to be this file https://github.com/akoyamp/geopolrisk-py/blob/main/geopolrisk/assessment/utils.py which is well below the level of scholarly effort required to publish here.

Should you decide to resubmit to JOSS, please ensure you substantially improve your codebase beforehand.

@arfon
Copy link
Member

arfon commented Oct 28, 2024

@editorialbot reject

@editorialbot
Copy link
Collaborator Author

Paper rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants