-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: PET2BIDS: a library for converting Positron Emission Tomography data to BIDS #6067
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
Failed to discover a valid open source license |
|
@nbeliy @adswa @pjtoussaint 👋 This is the review thread for the paper. All of our higher-level communications will happen here from now on, review comments and discussion can happen in the repository of the project (details below). 📓 Please read the "Reviewer instructions & questions" in the comment from our editorialbot. ✅ All reviewers get their own checklist with the JOSS requirements - you generate them as per the details in the editorialbot comment. As you go over the submission, please check any items that you feel have been satisfied. 💻 The JOSS review is different from most other journals: The reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention the link this issue (so that a link is created to this thread). That will also help me to keep track! ❓ Please also feel free to comment and ask questions on this thread. 🎯 We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. |
Review checklist for @nbeliyConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @adswaConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @pjtoussaintConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Looks like everyone has started their review, awesome! |
@pjtoussaint we have pushed some updates based on the other reviewers comments |
Hello everyone - just to say I am back in the office now. Looks like things are progressing, great! |
Hi everyone, |
getting there, retesting the read the doc (that crashes) and our CI -- @bendhouseart has been tasked to do those |
Yes, as Cyril mentioned I've been chipping away at the issues raised by @adswa and am currently wrapping up some changes holding @CPernet up with respect to openneuropet/PET2BIDS#236. I think that now we're all waiting on my completing and merging openneuropet/PET2BIDS PR #262. |
@CPernet and @bendhouseart - great! Thanks a lot for the update! |
Just for info, I'll be away for the next 2 week |
@nbeliy response posted in openneuropet/PET2BIDS#236 with the text updated - thx |
@adswa all the issues fixed by @bendhouseart should be all good now |
@britta-wstnr we had no feedback from @pjtoussaint ?? |
thx @britta-wstnr indeed, now using the GitHub repo URL instead openneuropet/PET2BIDS@3d431db |
@editorialbot generate pdf |
@editorialbot check references |
|
@CPernet great, thanks! Time to recommend acception of the paper - from here, the EiC will take over. @CPernet and @bendhouseart et al., if you are not signed up yet, please consider to sign up as a reviewer for JOSS: https://reviewers.joss.theoj.org/join . You can of course also recommend this to your co-authors 😉 Thanks everyone for working on this! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5783, then you can now move forward with accepting the submission by compiling again with the command |
@CPernet as AEiC for JOSS I will now help to process this submission for acceptance in JOSS. I have checked this review, your repository, the archive link, and the paper. Most seems in order, however the below are some points that require your attention:
|
@CPernet 👋 |
Hi @Kevin-Mattheus-Moerman. This should be updated now: openneuropet/PET2BIDS@fac5455 |
@editorialbot generate pdf |
Looks good now - thanks, @Kevin-Mattheus-Moerman ! |
We are ready to have this published :-) |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Many thanks @Kevin-Mattheus-Moerman and @britta-wstnr - it all looks good. @CPernet |
🎉🌈🦄💃👻🤘 |
thx for taking over @mnoergaard while I'm on holiday -- all good indeed (not sure how to close the issue now) |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @CPernet (Cyril Pernet)
Repository: https://github.com/openneuropet/PET2BIDS/
Branch with paper.md (empty if default branch): JOSS_paper
Version: v1.3.20240502
Editor: @britta-wstnr
Reviewers: @nbeliy, @adswa, @pjtoussaint
Archive: 10.5281/zenodo.11099654
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@nbeliy & @adswa & @pjtoussaint, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @britta-wstnr know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @nbeliy
📝 Checklist for @adswa
📝 Checklist for @pjtoussaint
The text was updated successfully, but these errors were encountered: