-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: StormR: An R package to quantify and map the tropical storms and cyclones’ winds characteristics #5766
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @highammConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @thomasarsouze, Would you be able to add the code generating the images in Figure 2 in https://github.com/umr-amap/StormR/tree/master/paper/images (or, if I've missed the code generating that Figure, could you point me in the right direction?) Thanks! |
Hi @thomasarsouze, I've opened up an issue at umr-amap/StormR#68. Thanks, and hope all is well! |
As stated in the caption of the figure, all plots were generated using |
Hey @thomasarsouze, thanks for the info! Would it be possible to add a link to the Spatial Behaviour article you reference in the Figure caption itself so that people reading the article know where to go to reproduce the sub-figures easily? |
Done in commit f25bf7b |
Hello @thomasarsouze, can you add some community guidelines (clear guidelines for third parties wishing to 1. Contribute to the software, 2. Report issues or problems with the software, 3. Seek support) to the Or, if these are given elsewhere, could you point me in the direction of where they are given? Thanks! |
Indeed this is missing information. |
Review checklist for @gsapijaszkoConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi all! It looks like this review has grown stale. @gsapijaszko have you run across any issues in your review? |
Hi, I'm really sorry it took so long. Went through the review during the weekend, in my humble opinion, the paper is well written and can be published. Regards, |
Thanks @gsapijaszko for coming back to us. You only mention the "paper", but JOSS is mostly about the code, the docs, and all the criteria as listed above. Can you let us know whether you installed the software and tested all the criteria? I am a bit confused by your wording here. |
@hugoledoux & @kthyng : sorry to bother you, but is there anything we can do here to not let this review last too long ? |
@gsapijaszko Could you check in on this review please? See question above. |
Hi. |
@thomasarsouze I am sorry for the delay here. I have just emailed @gsapijaszko to see if we might hear back about their review to see about next steps. Thank you. |
Yes, I have installed and tested the software. Otherwise I wouldn't mark check marks in review. Yes, I went through examples/help and played with the data. All criteria are met. I don't have anything to complain about, neither paper, neither software. Regards, |
Done! archive is now 10.5281/zenodo.10417763 |
@editorialbot set v0.1.2 as version |
@editorialbot recommend-accept |
|
|
@thomasarsouze it took longer than what we wanted, but in the end it's accepted just in time for the winter holidays 🎄☃️ thanks to @gsapijaszko and @highamm ! |
👋 @openjournals/ese-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4863, then you can now move forward with accepting the submission by compiling again with the command |
My steps:
|
@editorialbot set v0.1.2 as version |
Done! version is now v0.1.2 |
Not sure why that didn't stick before... |
@thomasarsouze A JOSS review is usually a good time to bump to a nice round version number like v1.0.0 — but up to you. |
Paper edits: umr-amap/StormR#79 |
@kthyng thanks for your inputs, they have been merged.
I prefer to stick to the current version, we have long-term developments that will later justify such a bump. |
@editorialbot generate pdf |
Ok looks ready to go! |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats on your new publication @thomasarsouze! Many thanks to editor @hugoledoux and reviewers @gsapijaszko and @highamm for your time, hard work, and expertise!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @thomasarsouze (Thomas Arsouze)
Repository: https://github.com/umr-amap/StormR
Branch with paper.md (empty if default branch):
Version: v0.1.2
Editor: @hugoledoux
Reviewers: @gsapijaszko, @highamm
Archive: 10.5281/zenodo.10417763
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@gsapijaszko & @highamm, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @hugoledoux know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @highamm
📝 Checklist for @gsapijaszko
The text was updated successfully, but these errors were encountered: