Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: Zoobot: Adaptable Deep Learning Models for Galaxy Morphology #5312

Closed
editorialbot opened this issue Mar 30, 2023 · 67 comments
Closed
Assignees
Labels
accepted Dockerfile HCL published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 30, 2023

Submitting author: @mwalmsley (Mike Walmsley)
Repository: https://github.com/mwalmsley/zoobot
Branch with paper.md (empty if default branch): docs
Version: v1.0.3
Editor: @plaplant
Reviewers: @crhea93, @devanshkv
Archive: 10.5281/zenodo.7896025

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/447561ee2de4709eddb704e18bee846f"><img src="https://joss.theoj.org/papers/447561ee2de4709eddb704e18bee846f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/447561ee2de4709eddb704e18bee846f/status.svg)](https://joss.theoj.org/papers/447561ee2de4709eddb704e18bee846f)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@crhea93 & @devanshkv, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @plaplant know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @devanshkv

📝 Checklist for @crhea93

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.19 s (673.5 files/s, 76798.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          66           2064           3281           4749
Markdown                         7            130              0            419
reStructuredText                29            345            345            325
TeX                              1             23              0            209
Bourne Shell                    10             84            146            208
Jupyter Notebook                 2              0           1638            158
YAML                             6             15             15            107
DOS Batch                        1              8              1             26
Dockerfile                       1              7              7             18
make                             1              4              7              9
HCL                              1              4              4              6
TOML                             1              0              0              6
-------------------------------------------------------------------------------
SUM:                           126           2684           5444           6240
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1255

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arxiv.2206.11927 is OK
- 10.1093/mnras/stab2093 is OK
- 10.48550/arXiv.1110.3193 is OK
- 10.1093/mnras/stz2816 is OK
- 10.48550/ARXIV.1603.04467 is OK
- 10.1017/S1743921319008615 is OK
- 10.1017/pasa.2022.55 is OK
- 10.1038/nature14539 is OK
- 10.48550/ARXIV.2302.05442 is OK
- 10.48550/ARXIV.2104.10972 is OK
- 10.5281/zenodo.4414861 is OK
- 10.5281/zenodo.3828935 is OK
- 10.48550/ARXIV.1711.10604 is OK
- 10.48550/ARXIV.2303.00366 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@devanshkv
Copy link

devanshkv commented Mar 30, 2023

Review checklist for @devanshkv

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/mwalmsley/zoobot?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@mwalmsley) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@plaplant
Copy link

plaplant commented Apr 9, 2023

@crhea93 thanks again for agreeing to review this submission! When you get a chance, please generate your reviewer checklist by replying to this thread with the comment

@editorialbot generate my checklist

Then, please read through the submission and update your checklist as you feel is appropriate. Let me know if you have any questions!

@crhea93
Copy link

crhea93 commented Apr 24, 2023

Review checklist for @crhea93

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/mwalmsley/zoobot?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@mwalmsley) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@crhea93
Copy link

crhea93 commented Apr 24, 2023

The authors is missing references in the software paper.

@crhea93
Copy link

crhea93 commented Apr 24, 2023

The requirements file is incorrectly formatted. There is also no reference to the requirements.txt file in the installation.

@plaplant
Copy link

@crhea93 thanks for reviewing the software! For issues that should be addressed as part of the review, please open issues on the upstream repository. Thanks!

@crhea93
Copy link

crhea93 commented Apr 25, 2023

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @crhea93, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@crhea93
Copy link

crhea93 commented Apr 25, 2023

@plaplant Should the issues have a specific template? I can't find one in the JOSS documentation.

@mwalmsley
Copy link

Hi @crhea93. Thanks for taking the time to review our JOSS submission!

The requirements file is incorrectly formatted. There is also no reference to the requirements.txt file in the installation.

The requirements.txt file is deprecated (the first line is """Deprecated - see setup.py""" and the entire file is commented out). I will remove it now for clarity. Installation dependencies are instead included via setup.py, which allows for more configuration (e.g. zoobot[pytorch], zoobot[tensorflow]).

The authors is missing references in the software paper.

Which references are missing? Do you mean missing as in 'should be cited' or 'not linked correctly to bibliography'?

I'm happy to chat directly on here about issues not related to the software itself, or you're welcome to open issues (I don't think a specific structure is required, it's only me reading them ;) )

@plaplant
Copy link

@crhea93 we do not have an official template, but thanks for checking! Sometimes reviewers make individual issues for each point they'd like addressed, and others make a single large "laundry list" issue. Either is fine, but my take is that having a separate issue for each point to be addressed can help keep the discussion more focused within the thread (and can potentially be addressed/fixed with multiple PRs).

In either case, you can link to the upstream issue(s) in this thread so everyone here can see the outstanding hurdles to acceptance. Thanks again for taking time to review!

@mwalmsley
Copy link

mwalmsley commented Apr 30, 2023

Hi reviewers @devanshkv @crhea93. Thank you for your feedback thus far.

I just wanted to highlight a few pieces of code that may be relevant to your remaining checklist items:

  • There is a Colab notebook for finetuning Zoobot. This is aimed at new users but can be used to verify the software works.
  • The models can be trained from scratch with using the scripts in /benchmarks to train the models from scratch. This is a manual functional test that new versions of Zoobot still perform well (and hopefully better). Results are uploaded to WandB and I'm happy to provide access to verify, if you like.
  • You can use the scripts to train most of the models yourself (though you will need some significant resources and potentially some adaption to your own cluster). All the data is provided in a separate repo, mwalmsley/galaxy-datasets, designed for easy use with ML. This includes GZ2, GZ CANDELS, GZ Hubble, and GZ DECALS. The only training data not yet available via that repo is GZ DESI, which is not original data in this paper - it is being published separately and is currently under review at MNRAS.
  • There are a few automated tests for some specific fiddly bits (see /tests) but mostly I find unit tests not that helpful for ML models. Having one-press slurm scripts to train the models has been much more useful to me.

@crhea93
Copy link

crhea93 commented Apr 30, 2023

@plaplant I've completed my review. I am very impressed with this work and @mwalmsley has cleared up any issues that I had. I recommend this code for publication.

@plaplant
Copy link

plaplant commented May 2, 2023

@crhea93 thanks very much for your review!

@devanshkv are there any outstanding issues that you feel need to be addressed prior to publication? If so, please make an issue on the upstream repository and reply to this thread so we're aware. Otherwise, if you feel this is ready for publication, please update your reviewer checklist accordingly. Thanks again for reviewing!

@devanshkv
Copy link

@crhea93, all good from my side.

Great work @mwalmsley! Looking forward to seeing how the community utilizes this. My only suggestion would be to have a more comprehensive test suite. Nevertheless, I recommend this code for publication.

@plaplant
Copy link

plaplant commented May 2, 2023

@devanshkv I see that there is still an unchecked item on your checklist about verifying the functional claims of the software. Please update your checklist accordingly if you have done this, or first verify the functionality before checking this box. (Per the JOSS reviewer docs, a review isn't complete until all items of the checklist have been ticked off.) Thanks!

@devanshkv
Copy link

@plaplant apologies, that was left unticked by mistake. All good from my side now.

@plaplant
Copy link

plaplant commented May 2, 2023

@devanshkv thanks for the quick response!

@mwalmsley both reviewers have recommended acceptance of the submission, so we can move forward with the final acceptance checks. If the software has changed in the course of the review, please make a new tagged release of the repository. After that, please archive it (on Zenodo, figshare, or some other long-term hosting platform). Once those are done, please post the version number and DOI of the archive in this thread. Let me know if you have any questions!

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@plaplant
Copy link

plaplant commented May 7, 2023

@mwalmsley fantastic! Thanks so much. I think this is ready to go.

@plaplant
Copy link

plaplant commented May 7, 2023

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arxiv.2206.11927 is OK
- 10.1093/mnras/stab2093 is OK
- 10.48550/arXiv.1110.3193 is OK
- 10.1093/mnras/stz2816 is OK
- 10.48550/ARXIV.1603.04467 is OK
- 10.1017/S1743921319008615 is OK
- 10.1017/pasa.2022.55 is OK
- 10.1038/nature14539 is OK
- 10.48550/ARXIV.2302.05442 is OK
- 10.48550/arXiv.2108.07258 is OK
- 10.48550/ARXIV.2104.10972 is OK
- 10.5281/zenodo.4414861 is OK
- 10.48550/arXiv.1912.11554 is OK
- 10.5281/zenodo.3828935 is OK
- 10.48550/ARXIV.1711.10604 is OK
- 10.48550/ARXIV.2303.00366 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

The paper's PDF and metadata files generation produced some warnings that could prevent the final paper from being published. Please fix them before the end of the review process.

citation bingham2018pyro not found

@editorialbot
Copy link
Collaborator Author

⚠️ Error preparing paper acceptance. The generated XML metadata file is invalid.

IDREFS attribute rid references an unknown ID "ref-bingham2018pyro"

@plaplant
Copy link

plaplant commented May 7, 2023

@mwalmsley it looks like the reference to Pyro in the paper.md file did not get updated to the new citation key in paper.bib. I think once that is updated, this error should go away.

@mwalmsley
Copy link

mwalmsley commented May 7, 2023 via email

@plaplant
Copy link

plaplant commented May 7, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@plaplant
Copy link

plaplant commented May 8, 2023

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arxiv.2206.11927 is OK
- 10.1093/mnras/stab2093 is OK
- 10.48550/arXiv.1110.3193 is OK
- 10.1093/mnras/stz2816 is OK
- 10.48550/ARXIV.1603.04467 is OK
- 10.1017/S1743921319008615 is OK
- 10.1017/pasa.2022.55 is OK
- 10.1038/nature14539 is OK
- 10.48550/ARXIV.2302.05442 is OK
- 10.48550/arXiv.2108.07258 is OK
- 10.48550/ARXIV.2104.10972 is OK
- 10.5281/zenodo.4414861 is OK
- 10.48550/arXiv.1912.11554 is OK
- 10.5281/zenodo.3828935 is OK
- 10.48550/ARXIV.1711.10604 is OK
- 10.48550/ARXIV.2303.00366 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4206, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@editorialbot editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label May 8, 2023
@dfm
Copy link

dfm commented May 8, 2023

@editorialbot accept

@editorialbot
Copy link
Collaborator Author

Doing it live! Attempting automated processing of paper acceptance...

1 similar comment
@editorialbot
Copy link
Collaborator Author

Doing it live! Attempting automated processing of paper acceptance...

@editorialbot
Copy link
Collaborator Author

⚠️ Couldn't acccept/publish paper. An error happened.

@editorialbot
Copy link
Collaborator Author

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- family-names: Walmsley
  given-names: Mike
  orcid: "https://orcid.org/0000-0002-6408-4181"
- family-names: Allen
  given-names: Campbell
- family-names: Aussel
  given-names: Ben
  orcid: "https://orcid.org/0000-0003-2592-6806"
- family-names: Bowles
  given-names: Micah
  orcid: "https://orcid.org/0000-0001-5838-8405"
- family-names: Gregorowicz
  given-names: Kasia
  orcid: "https://orcid.org/0009-0003-0023-6240"
- family-names: Slijepcevic
  given-names: Inigo Val
  orcid: "https://orcid.org/0000-0002-7056-9599"
- family-names: Lintott
  given-names: Chris J.
  orcid: "https://orcid.org/0000-0001-5578-359X"
- family-names: Scaife
  given-names: Anna M. M.
  orcid: "https://orcid.org/0000-0002-5364-2301"
- family-names: Jabłońska
  given-names: Maja
  orcid: "https://orcid.org/0000-0001-6962-4979"
- family-names: Karchev
  given-names: Kosio
  orcid: "https://orcid.org/0000-0001-9344-736X"
- family-names: Lanzieri
  given-names: Denise
  orcid: "https://orcid.org/0000-0003-2787-1634"
- family-names: Mohan
  given-names: Devina
  orcid: "https://orcid.org/0000-0002-8566-7968"
- family-names: O'Ryan
  given-names: David
  orcid: "https://orcid.org/0000-0003-1217-4617"
- family-names: Saiguhan
  given-names: Bharath
  orcid: "https://orcid.org/0000-0001-7580-364X"
- family-names: Suárez
  given-names: Crisel
  orcid: "https://orcid.org/0000-0001-5243-7659"
- family-names: Guerra-Varas
  given-names: Nicolás
  orcid: "https://orcid.org/0000-0002-9718-6352"
- family-names: Velu
  given-names: Renuka
contact:
- family-names: Walmsley
  given-names: Mike
  orcid: "https://orcid.org/0000-0002-6408-4181"
doi: 10.5281/zenodo.7896025
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - family-names: Walmsley
    given-names: Mike
    orcid: "https://orcid.org/0000-0002-6408-4181"
  - family-names: Allen
    given-names: Campbell
  - family-names: Aussel
    given-names: Ben
    orcid: "https://orcid.org/0000-0003-2592-6806"
  - family-names: Bowles
    given-names: Micah
    orcid: "https://orcid.org/0000-0001-5838-8405"
  - family-names: Gregorowicz
    given-names: Kasia
    orcid: "https://orcid.org/0009-0003-0023-6240"
  - family-names: Slijepcevic
    given-names: Inigo Val
    orcid: "https://orcid.org/0000-0002-7056-9599"
  - family-names: Lintott
    given-names: Chris J.
    orcid: "https://orcid.org/0000-0001-5578-359X"
  - family-names: Scaife
    given-names: Anna M. M.
    orcid: "https://orcid.org/0000-0002-5364-2301"
  - family-names: Jabłońska
    given-names: Maja
    orcid: "https://orcid.org/0000-0001-6962-4979"
  - family-names: Karchev
    given-names: Kosio
    orcid: "https://orcid.org/0000-0001-9344-736X"
  - family-names: Lanzieri
    given-names: Denise
    orcid: "https://orcid.org/0000-0003-2787-1634"
  - family-names: Mohan
    given-names: Devina
    orcid: "https://orcid.org/0000-0002-8566-7968"
  - family-names: O'Ryan
    given-names: David
    orcid: "https://orcid.org/0000-0003-1217-4617"
  - family-names: Saiguhan
    given-names: Bharath
    orcid: "https://orcid.org/0000-0001-7580-364X"
  - family-names: Suárez
    given-names: Crisel
    orcid: "https://orcid.org/0000-0001-5243-7659"
  - family-names: Guerra-Varas
    given-names: Nicolás
    orcid: "https://orcid.org/0000-0002-9718-6352"
  - family-names: Velu
    given-names: Renuka
  date-published: 2023-05-08
  doi: 10.21105/joss.05312
  issn: 2475-9066
  issue: 85
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 5312
  title: "Zoobot: Adaptable Deep Learning Models for Galaxy Morphology"
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.05312"
  volume: 8
title: "Zoobot: Adaptable Deep Learning Models for Galaxy Morphology"

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

@editorialbot
Copy link
Collaborator Author

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

@editorialbot
Copy link
Collaborator Author

⚠️ Couldn't acccept/publish paper. An error happened.

@dfm
Copy link

dfm commented May 8, 2023

I got the bot mixed up by asking it to accept twice, but those error messages are not correct... here's what it should have said (note that while the DOI already resolves it may take a little while for the actual manuscript to show up because of caching issues):

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.05340 joss-papers#4204
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05312
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@dfm
Copy link

dfm commented May 8, 2023

Many thanks to @crhea93 and @devanshkv for reviewing and to @plaplant for editing! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!!

@mwalmsley — Your paper is now accepted and published in JOSS! ⚡🚀💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Dockerfile HCL published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences
Projects
None yet
Development

No branches or pull requests

6 participants