-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Zoobot: Adaptable Deep Learning Models for Galaxy Morphology #5312
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @devanshkvConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@crhea93 thanks again for agreeing to review this submission! When you get a chance, please generate your reviewer checklist by replying to this thread with the comment
Then, please read through the submission and update your checklist as you feel is appropriate. Let me know if you have any questions! |
Review checklist for @crhea93Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
The authors is missing references in the software paper. |
The requirements file is incorrectly formatted. There is also no reference to the requirements.txt file in the installation. |
@crhea93 thanks for reviewing the software! For issues that should be addressed as part of the review, please open issues on the upstream repository. Thanks! |
@editorialbot commands |
Hello @crhea93, here are the things you can ask me to do:
|
@plaplant Should the issues have a specific template? I can't find one in the JOSS documentation. |
Hi @crhea93. Thanks for taking the time to review our JOSS submission!
The
Which references are missing? Do you mean missing as in 'should be cited' or 'not linked correctly to bibliography'? I'm happy to chat directly on here about issues not related to the software itself, or you're welcome to open issues (I don't think a specific structure is required, it's only me reading them ;) ) |
@crhea93 we do not have an official template, but thanks for checking! Sometimes reviewers make individual issues for each point they'd like addressed, and others make a single large "laundry list" issue. Either is fine, but my take is that having a separate issue for each point to be addressed can help keep the discussion more focused within the thread (and can potentially be addressed/fixed with multiple PRs). In either case, you can link to the upstream issue(s) in this thread so everyone here can see the outstanding hurdles to acceptance. Thanks again for taking time to review! |
Hi reviewers @devanshkv @crhea93. Thank you for your feedback thus far. I just wanted to highlight a few pieces of code that may be relevant to your remaining checklist items:
|
@plaplant I've completed my review. I am very impressed with this work and @mwalmsley has cleared up any issues that I had. I recommend this code for publication. |
@crhea93 thanks very much for your review! @devanshkv are there any outstanding issues that you feel need to be addressed prior to publication? If so, please make an issue on the upstream repository and reply to this thread so we're aware. Otherwise, if you feel this is ready for publication, please update your reviewer checklist accordingly. Thanks again for reviewing! |
@crhea93, all good from my side. Great work @mwalmsley! Looking forward to seeing how the community utilizes this. My only suggestion would be to have a more comprehensive test suite. Nevertheless, I recommend this code for publication. |
@devanshkv I see that there is still an unchecked item on your checklist about verifying the functional claims of the software. Please update your checklist accordingly if you have done this, or first verify the functionality before checking this box. (Per the JOSS reviewer docs, a review isn't complete until all items of the checklist have been ticked off.) Thanks! |
@plaplant apologies, that was left unticked by mistake. All good from my side now. |
@devanshkv thanks for the quick response! @mwalmsley both reviewers have recommended acceptance of the submission, so we can move forward with the final acceptance checks. If the software has changed in the course of the review, please make a new tagged release of the repository. After that, please archive it (on Zenodo, figshare, or some other long-term hosting platform). Once those are done, please post the version number and DOI of the archive in this thread. Let me know if you have any questions! |
@mwalmsley fantastic! Thanks so much. I think this is ready to go. |
@editorialbot recommend-accept |
|
|
The paper's PDF and metadata files generation produced some warnings that could prevent the final paper from being published. Please fix them before the end of the review process.
|
IDREFS attribute rid references an unknown ID "ref-bingham2018pyro" |
@mwalmsley it looks like the reference to Pyro in the |
Ah, didn't notice the year changed - should be fixed now.
…On Sun, May 7, 2023 at 6:21 PM Paul La Plante ***@***.***> wrote:
@mwalmsley <https://github.com/mwalmsley> it looks like the reference to
Pyro in the paper.md file
<https://github.com/mwalmsley/zoobot/blob/ca3fb1a862d7bf4d271590627592281afcf458f3/paper/paper.md?plain=1#L194>
did not get updated to the new citation key in paper.bib
<https://github.com/mwalmsley/zoobot/blob/ca3fb1a862d7bf4d271590627592281afcf458f3/paper/paper.bib#L186>.
I think once that is updated, this error should go away.
—
Reply to this email directly, view it on GitHub
<#5312 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3BY3W3USKOYSDHMTUVWXTXE7KY5ANCNFSM6AAAAAAWMUBWTM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
👋 @openjournals/aass-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4206, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
1 similar comment
|
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
|
I got the bot mixed up by asking it to accept twice, but those error messages are not correct... here's what it should have said (note that while the DOI already resolves it may take a little while for the actual manuscript to show up because of caching issues): 🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Many thanks to @crhea93 and @devanshkv for reviewing and to @plaplant for editing! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!! @mwalmsley — Your paper is now accepted and published in JOSS! ⚡🚀💥 |
Submitting author: @mwalmsley (Mike Walmsley)
Repository: https://github.com/mwalmsley/zoobot
Branch with paper.md (empty if default branch): docs
Version: v1.0.3
Editor: @plaplant
Reviewers: @crhea93, @devanshkv
Archive: 10.5281/zenodo.7896025
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@crhea93 & @devanshkv, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @plaplant know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @devanshkv
📝 Checklist for @crhea93
The text was updated successfully, but these errors were encountered: