Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: scene_synthesizer: A Python Library for Procedural Scene Generation in Robot Manipulation #7514

Closed
editorialbot opened this issue Nov 22, 2024 · 47 comments
Assignees
Labels
pre-review Python Shell TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Nov 22, 2024

Submitting author: @clemense (Clemens Eppner)
Repository: https://github.com/NVlabs/scene_synthesizer
Branch with paper.md (empty if default branch):
Version: 1.11.4
Editor: @crvernon
Reviewers: @AlexanderFabisch, @Mechazo11
Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d32b27b7e95469107bf1bbe3bdb2683a"><img src="https://joss.theoj.org/papers/d32b27b7e95469107bf1bbe3bdb2683a/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d32b27b7e95469107bf1bbe3bdb2683a/status.svg)](https://joss.theoj.org/papers/d32b27b7e95469107bf1bbe3bdb2683a)

Author instructions

Thanks for submitting your paper to JOSS @clemense. Currently, there isn't a JOSS editor assigned to your paper.

@clemense if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Nov 22, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.31 s (270.9 files/s, 297898.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
XML                             15              0              0          61681
Python                          37           4159           4639          18698
reStructuredText                17            327            672            248
TeX                              2             25              2            237
CSS                              1             42             17            148
Markdown                         4             30              0            139
Bourne Shell                     1              5              3             62
YAML                             2              3              0             29
TOML                             1              5             12             22
HTML                             1              1              0             13
make                             1              3              0             11
Dockerfile                       1              6             17              3
-------------------------------------------------------------------------------
SUM:                            83           4606           5362          81291
-------------------------------------------------------------------------------

Commit count by author:

    17	Clemens Eppner

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 533

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: Apache License 2.0 (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.21105/joss.04901 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: A Procedural World Generation Framework for System...
- No DOI given, and none found for title: Habitat 2.0: Training Home Assistants to Rearrange...
- No DOI given, and none found for title: ProcTHOR: Large-Scale Embodied AI Using Procedural...
- No DOI given, and none found for title: RoboCasa: Large-Scale Simulation of Everyday Tasks...
- No DOI given, and none found for title: DiffuScene: Scene Graph Denoising Diffusion Probab...
- No DOI given, and none found for title: RoboPoint: A Vision-Language Model for Spatial Aff...
- No DOI given, and none found for title: Motion Policy Networks
- No DOI given, and none found for title: Imitating Task and Motion Planning with Visuomotor...
- No DOI given, and none found for title: Scenic: A Language for Scenario Specification and ...
- No DOI given, and none found for title: M2T2: Multi-Task Masked Transformer for Object-cen...
- No DOI given, and none found for title: Fidgit: An ungodly union of GitHub and Figshare
- No DOI given, and none found for title: trimesh
- No DOI given, and none found for title: Techniques for training machine learning models us...

❌ MISSING DOIs

- 10.1109/icra40945.2020.9196910 may be a valid DOI for title: Generative modeling of environments with scene gra...
- 10.1109/cvpr.2019.00100 may be a valid DOI for title: PartNet: A Large-Scale Benchmark for Fine-Grained ...
- 10.1109/iccv.2019.00943 may be a valid DOI for title: Habitat: A Platform for Embodied AI Research
- 10.1109/cvpr46437.2021.00447 may be a valid DOI for title: ManipulaTHOR: A Framework for Visual Object Manipu...
- 10.1109/cvpr42600.2020.01111 may be a valid DOI for title: SAPIEN: A SimulAted Part-based Interactive ENviron...
- 10.1109/cvpr52688.2022.00373 may be a valid DOI for title: Kubric: a scalable dataset generator
- 10.1109/cvpr52729.2023.01215 may be a valid DOI for title: Infinite Photorealistic Worlds Using Procedural Ge...
- 10.1109/cvpr52733.2024.00593 may be a valid DOI for title: ControlRoom3D: Room Generation using Semantic Prox...
- 10.1109/iccv51070.2023.00727 may be a valid DOI for title: Text2Room: Extracting Textured 3D Meshes from 2D T...
- 10.1109/icra48891.2023.10161528 may be a valid DOI for title: CabiNet: Scaling Neural Collision Detection for Ob...
- 10.1109/iros.2018.8594495 may be a valid DOI for title: The RobotriX: An eXtremely Photorealistic and Very...
- 10.1109/cvpr52733.2024.01539 may be a valid DOI for title: PhyScene: Physically Interactable 3D Scene Synthes...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

sbp-env: A Python Package for Sampling-based Motion Planner and Samplers
Submitting author: @soraxas
Handling editor: @danielskatz (Active)
Reviewers: @KanishAnand, @OlgerSiebinga
Similarity score: 0.7143

Abmarl: Connecting Agent-Based Simulations with Multi-Agent Reinforcement Learning
Submitting author: @rusu24edward
Handling editor: @drvinceknight (Active)
Reviewers: @seba-1511, @abhiramm7
Similarity score: 0.7111

unifir: A Unifying API for Working with Unity in R
Submitting author: @mikemahoney218
Handling editor: @kyleniemeyer (Active)
Reviewers: @kyleniemeyer
Similarity score: 0.6848

The o80 C++ templated toolbox: Designing customized Python APIs for synchronizing realtime processes
Submitting author: @vincentberenz
Handling editor: @gkthiruvathukal (Active)
Reviewers: @traversaro, @vissarion
Similarity score: 0.6828

Zoobot: Adaptable Deep Learning Models for Galaxy Morphology
Submitting author: @mwalmsley
Handling editor: @plaplant (Active)
Reviewers: @crhea93, @devanshkv
Similarity score: 0.6721

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@clemense
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @clemense, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@clemense
Copy link

@editorialbot generate preprint

@editorialbot
Copy link
Collaborator Author

📄 Preprint file created: Find it here in the Artifacts list 📄

@crvernon
Copy link

👋 @clemense - could you explain the low commit history in your repo? Was this brought in from elsewhere? Thanks

@clemense
Copy link

Yes, this was brought in from an internal repo. History was squashed.

@crvernon
Copy link

Thanks @clemense. Please take care of the missing DOI listed above in this thread while I get you a topic editor assigned.

@crvernon
Copy link

@editorialbot invite @Fei-Tao as editor

👋 @Fei-Tao - can you take this one on as editor?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@clemense
Copy link

@editorialbot generate preprint

@editorialbot
Copy link
Collaborator Author

📄 Preprint file created: Find it here in the Artifacts list 📄

@crvernon
Copy link

@editorialbot generate pdf

@crvernon
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.30 s (274.6 files/s, 301933.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
XML                             15              0              0          61681
Python                          37           4159           4639          18698
reStructuredText                17            327            672            248
TeX                              2             25              2            237
CSS                              1             42             17            148
Markdown                         4             30              0            139
Bourne Shell                     1              5              3             62
YAML                             2              3              0             29
TOML                             1              5             12             22
HTML                             1              1              0             13
make                             1              3              0             11
Dockerfile                       1              6             17              3
-------------------------------------------------------------------------------
SUM:                            83           4606           5362          81291
-------------------------------------------------------------------------------

Commit count by author:

    17	Clemens Eppner

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 533

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: Apache License 2.0 (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

sbp-env: A Python Package for Sampling-based Motion Planner and Samplers
Submitting author: @soraxas
Handling editor: @danielskatz (Active)
Reviewers: @KanishAnand, @OlgerSiebinga
Similarity score: 0.7140

Abmarl: Connecting Agent-Based Simulations with Multi-Agent Reinforcement Learning
Submitting author: @rusu24edward
Handling editor: @drvinceknight (Active)
Reviewers: @seba-1511, @abhiramm7
Similarity score: 0.7111

unifir: A Unifying API for Working with Unity in R
Submitting author: @mikemahoney218
Handling editor: @kyleniemeyer (Active)
Reviewers: @kyleniemeyer
Similarity score: 0.6843

The o80 C++ templated toolbox: Designing customized Python APIs for synchronizing realtime processes
Submitting author: @vincentberenz
Handling editor: @gkthiruvathukal (Active)
Reviewers: @traversaro, @vissarion
Similarity score: 0.6827

Zoobot: Adaptable Deep Learning Models for Galaxy Morphology
Submitting author: @mwalmsley
Handling editor: @plaplant (Active)
Reviewers: @crhea93, @devanshkv
Similarity score: 0.6723

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@clemense
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1109/icra40945.2020.9196910 is OK
- 10.21105/joss.04901 is OK
- 10.1109/cvpr.2019.00100 is OK
- 10.1109/iccv.2019.00943 is OK
- 10.1109/cvpr46437.2021.00447 is OK
- 10.1109/cvpr42600.2020.01111 is OK
- 10.1109/cvpr52688.2022.00373 is OK
- 10.1109/cvpr52729.2023.01215 is OK
- 10.1109/cvpr52733.2024.00593 is OK
- 10.1109/iccv51070.2023.00727 is OK
- 10.1109/icra48891.2023.10161528 is OK
- 10.1109/iros.2018.8594495 is OK
- 10.1109/cvpr52733.2024.01539 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: A Procedural World Generation Framework for System...
- No DOI given, and none found for title: Habitat 2.0: Training Home Assistants to Rearrange...
- No DOI given, and none found for title: ProcTHOR: Large-Scale Embodied AI Using Procedural...
- No DOI given, and none found for title: RoboCasa: Large-Scale Simulation of Everyday Tasks...
- No DOI given, and none found for title: DiffuScene: Scene Graph Denoising Diffusion Probab...
- No DOI given, and none found for title: RoboPoint: A Vision-Language Model for Spatial Aff...
- No DOI given, and none found for title: Motion Policy Networks
- No DOI given, and none found for title: Imitating Task and Motion Planning with Visuomotor...
- No DOI given, and none found for title: Scenic: A Language for Scenario Specification and ...
- No DOI given, and none found for title: M2T2: Multi-Task Masked Transformer for Object-cen...
- No DOI given, and none found for title: Fidgit: An ungodly union of GitHub and Figshare
- No DOI given, and none found for title: trimesh
- No DOI given, and none found for title: Techniques for training machine learning models us...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@Fei-Tao
Copy link

Fei-Tao commented Nov 26, 2024

Hi @crvernon thanks for your invitation to edit this submission. Unfortunately, I am currently handling several other submissions and have multiple upcoming travels. I do not have the bandwidth to take on this one.

@crvernon
Copy link

@editorialbot invite @jromanowska as editor

👋 @jromanowska - are you available to take this one on as editor?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@jromanowska
Copy link

Hi, sorry to say no, but I don't know anything about the field this software aims at. (I'm also on sick leave this week)

@crvernon
Copy link

No problem @jromanowska, I hope you feel better soon!

@crvernon
Copy link

@editorialbot assign me as editor

👋 @clemense - I think I'll just take this one on myself. Please recommend a few reviewers for me if you can. Thanks!

@editorialbot
Copy link
Collaborator Author

Assigned! @crvernon is now the editor

@clemense
Copy link

clemense commented Dec 2, 2024

Thank you! Just from searching through the reviewers and their expertise, some potential picks: Sam Wilcock, Gautam Sharma, Azmyin Md. Kamal, Martin Huber, Alexander Fabisch

@crvernon
Copy link

crvernon commented Dec 2, 2024

👋 @Mechazo11 - Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@crvernon
Copy link

crvernon commented Dec 2, 2024

👋 @AlexanderFabisch - Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@AlexanderFabisch
Copy link

@crvernon Yes, I would like to review this submission.

@crvernon
Copy link

crvernon commented Dec 3, 2024

@editorialbot add @AlexanderFabisch as reviewer

Thank you @AlexanderFabisch! Once I have two reviewers assigned, I'll kick off the main review thread.

@editorialbot
Copy link
Collaborator Author

@AlexanderFabisch added to the reviewers list!

@Mechazo11
Copy link

Hi @crvernon, it will be my pleasure to review this paper. Would be a valuable experience for me. But, before I commit though, what is the tentative deadline to turn in the review?

@crvernon
Copy link

crvernon commented Dec 3, 2024

Thanks @Mechazo11 ... around 4 to 6 weeks to finish up your review. Does that sound good to you?

@Mechazo11
Copy link

Hi @crvernon yes that should be adequate.

@crvernon
Copy link

crvernon commented Dec 3, 2024

@editorialbot add @Mechazo11 as reviewer

@editorialbot
Copy link
Collaborator Author

@Mechazo11 added to the reviewers list!

@crvernon
Copy link

crvernon commented Dec 3, 2024

@editorialbot start review

👋 - Alright @clemense, @AlexanderFabisch, and @Mechazo11 - I am going to close this Pre-Review and kick off the full review which you should receive a notification for. Thanks!

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7561.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python Shell TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

7 participants