-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: dtrackr: An R package for tracking the provenance of data #4707
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @craig-willisConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
I just wanted to mention that in the branch here under review, the README.md instructions say that "dtrackr" is not yet on CRAN. This is not correct and the version in the joss review branch (release-0.2.4) of dtrackr is now on CRAN and can be installed with a install.packages("dtrackr") command. I'm holding back on updating the documentation until I get comments back from you guys. Then I'll make any outstanding fixes update the documentation and push a 0.2.5 release through the CRAN submission process (with the updated installation instructions showing it is on CRAN). I've just made the exact same mistake on another package I'm submitting to CRAN :-) |
👋 @debruine how's your review going? |
I've been working through @craig-willis comments, and made quite a few updates. These are in a new branch joss-fixes-0.2.4.9000. Would it be better to do additional review there? |
I’m sorry I got swamped with work and am running late. I’ll start my review in this branch and aim to complete by Monday.
… On 5 Oct 2022, at 00:47, Rob Challen ***@***.***> wrote:
I've been working through @craig-willis comments, and made quite a few updates. These are in a new branch joss-fixes-0.2.4.9000. Would it be better to do additional review there?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Sure - I'll set that as the review branch now. |
@editorialbot set joss-fixes-0.2.4.9000 as branch |
Done! branch is now joss-fixes-0.2.4.9000 |
@editorialbot generate pdf |
Review checklist for @debruineConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@Kevin-Mattheus-Moerman thank you. fixed that. |
@editorialbot recommend-accept |
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3802, then you can now move forward with accepting the submission by compiling again with the command |
|
@editorialbot set main as branch |
Done! branch is now main |
@editorialbot generate pdf |
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations @robchallen on this JOSS publication! Thank you @ajstewartlang for editing!!! And a special thanks to the reviewers @debruine and @craig-willis !!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Many thanks for all the input @craig-willis @debruine @Kevin-Mattheus-Moerman @ajstewartlang. Very pleased to get this out. Have a great Xmas! |
Submitting author: @robchallen (Robert Challen)
Repository: https://github.com/terminological/dtrackr
Branch with paper.md (empty if default branch): main
Version: 0.2.5-joss
Editor: @ajstewartlang
Reviewers: @debruine, @craig-willis
Archive: 10.5281/zenodo.7433514
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@debruine & @craig-willis, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @ajstewartlang know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @craig-willis
📝 Checklist for @debruine
The text was updated successfully, but these errors were encountered: