-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: itmlogic: Longley Rice Irregular Terrain Model #2266
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @gorlapraveen, @garrettj403 it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
👋 @gorlapraveen & @garrettj403 - thanks for agreeing to review this submission. Please be sure to read the comments above, and let me know if you have any questions. Basically, your job is to check the article proof and repository and check items off your checklist above. If you see small problems that need to be discussed, feel free to discuss them here. But if you can, create a new issue in the target repository and link to this review thread in that issue to create corresponding breadcrumb trail here. I look forward to seeing how this review goes |
Hello @edwardoughton, I have a couple comments on your paper:
Overall, the paper was very well-written. The software was also easy to install on my computer and I hope to finish reviewing the code in the next couple days. Note: I had the same issue as @gorlapraveen that he raised in issue #34 (missing |
Thanks @garrettj403 - if you and @gorlapraveen can add a link to this issue (#2266) in any issues you open in the source repo, the will be flagged here and anyone looking at this issue will be able to tell if they are open or closed as well. |
Thank you for the review feedback @garrettj403 and @gorlapraveen, we're working to turn these corrections around. |
@garrettj403 I've now made most of those changes. I'm not sure the reference is wonky for the last entry in the bib as this is a citation of the website that releases the code. I think ITS seems like the right author, as it's their website, but I'm happy to be convinced otherwise. |
@whedon generate pdf |
the bib problem is in formatting - please merge edwardoughton/itmlogic#39 to fix it (and some other bib problems) |
then you can put in a new comment here with |
@whedon generate pdf |
@gorlapraveen - we need changes in the repo before it's useful to regenerate the pdf. |
@whedon generate pdf |
@gorlapraveen @garrettj403 @danielskatz I think that fixed the bibliography ordering plus capitalizations. Please let me know if there is anything else. |
I'm not sure why you made changes manually rather than just merging the PR. You missed the {}s around MHz and GHz. Otherwise, it looks ok to me. |
@whedon generate pdf |
Apologies Daniel, I missed the PR! Thanks for that. I hope this is resolved now. |
no problem |
thanks @garrettj403! I now look forward to hearing from @gorlapraveen |
Hi @edwardoughton, the functionality and the use of algorithms is technically quite satisfying. However, I would also suggest you to document where User inputs can be given. Such as where to change the operating frequencies for different modes. This would be my final comment and we can proceed for publication. |
@gorlapraveen I've now adapted the example running scripts and the documentation to reflect the main user defined parameters. This includes having a dict which contains the main parameters which the user can concisely state before calling the I also separated out the example scripts which use either 1 DEM tile or 2 DEM tiles, to overcome the issue of working across large areas which some users will need to deal with. The documentation also now reflects these changes. Thanks for the review feedback, Ed |
@edwardoughton Thanks for the changes. Looks great! |
Fantastic, thanks for the review @gorlapraveen. |
thanks @gorlapraveen! |
@edwardoughton - at this point, please:
I can then move forward with accepting the submission, which will include me proofreading the paper and the references. |
Thanks @danielskatz, I should now have completed those tasks. Please let me know if I missed anything. DOI: 10.5281/zenodo.3931350 Zonodo link: https://zenodo.org/record/3931350#.XwLumihKh9M |
@whedon set v1.1 as version |
OK. v1.1 is the version. |
@whedon set 10.5281/zenodo.3931350 as archive |
OK. 10.5281/zenodo.3931350 is the archive. |
@whedon generate pdf |
@whedon accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#1548 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1548, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Thanks to @gorlapraveen & @garrettj403 for reviewing! Congratulations to @edwardoughton (Edward J. Oughton) and co-authors!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @edwardoughton (Edward J. Oughton)
Repository: https://github.com/edwardoughton/itmlogic
Version: v1.1
Editor: @danielskatz
Reviewer: @gorlapraveen, @garrettj403
Archive: 10.5281/zenodo.3931350
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@gorlapraveen & @garrettj403, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danielskatz know.
✨ Please try and complete your review in the next six weeks ✨
Review checklist for @gorlapraveen
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @garrettj403
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: