Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: itmlogic: Longley Rice Irregular Terrain Model #2255

Closed
whedon opened this issue May 26, 2020 · 29 comments
Closed

[PRE REVIEW]: itmlogic: Longley Rice Irregular Terrain Model #2255

whedon opened this issue May 26, 2020 · 29 comments

Comments

@whedon
Copy link

whedon commented May 26, 2020

Submitting author: @edwardoughton (Edward J. Oughton)
Repository: https://github.com/edwardoughton/itmlogic
Version: v1
Editor: @danielskatz
Reviewers: @gorlapraveen, @garrettj403
Managing EiC: Daniel S. Katz

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @edwardoughton. Currently, there isn't an JOSS editor assigned to your paper.

@edwardoughton if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented May 26, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 26, 2020

PDF failed to compile for issue #2255 with the following error:

Can't find any papers to compile :-(

@danielskatz
Copy link

Note that @hugoledoux was suggested as the editor

@whedon
Copy link
Author

whedon commented May 26, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.39 s (162.7 files/s, 15635.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          47            883            731           3455
Markdown                         3             84              0            172
reStructuredText                 4            103            129            155
MATLAB                           1             26             40             70
TeX                              1              0              0             52
YAML                             2              8              3             33
DOS Batch                        1              8              1             26
CSS                              1              2              2             25
XML                              1              0              0             20
make                             1              4              7              9
INI                              1              4              0              4
-------------------------------------------------------------------------------
SUM:                            63           1122            913           4021
-------------------------------------------------------------------------------


Statistical information for the repository '2255' was gathered on 2020/05/26.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Tom Russell                     12           570            518            6.44
ej550                           76         10515           5298           93.56

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Tom Russell                 259           45.4          0.8               14.67
edwardoughton              4810          100.0          3.8                5.80

@whedon
Copy link
Author

whedon commented May 26, 2020

Reference check summary:

OK DOIs

- 10.1016/j.tele.2019.01.003 is OK
- 10.1109/ACCESS.2019.2949460 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@danielskatz
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 26, 2020

@danielskatz
Copy link

@whedon assign @danielskatz as editor

@whedon
Copy link
Author

whedon commented May 26, 2020

OK, the editor is @danielskatz

@danielskatz
Copy link

👋 @edwardoughton - Please suggest some potential reviewers (without tagging them with an @).

This list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Or if you have other suggestions for potential reviewers, then please mention them here.

@edwardoughton
Copy link

Potential reviewer: @mychele (Michele Polese)

@danielskatz
Copy link

Thanks - given that we will need to find 2 reviewers, more suggestions would also be welcome (please note the comment above "(without tagging them with an @)" as well)

@danielskatz
Copy link

👋 @mychele - Would you be willing to review this submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

@edwardoughton
Copy link

Thanks for the guidance Daniel.

Potential reviewer - alirazaanis - creator of the community cellular planner repo.

@danielskatz
Copy link

👋 @alirazaanis - Would you be willing to review this submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

@edwardoughton
Copy link

Potential reviewer: gorlapraveen (previous JOSS reviewer - knows radio/electrical engineering etc. - uses python)

@edwardoughton
Copy link

edwardoughton commented May 26, 2020

Potential reviewer: garrettj403 (previous JOSS reviewer - knows radio/electrical engineering etc. - uses python)

@edwardoughton
Copy link

Potential reviewer: peterl3233 (RF engineer who also codes)

@danielskatz
Copy link

👋 @gorlapraveen - Would you be willing to review this submission for JOSS?

@gorlapraveen
Copy link

wave @gorlapraveen - Would you be willing to review this submission for JOSS?

@danielskatz I wish to review!

@danielskatz
Copy link

Thanks @gorlapraveen - I'll add you into the system, but we won't start the review until we find at least one more reviewer as well.

@danielskatz
Copy link

@whedon assign @gorlapraveen as reviewer

@whedon whedon assigned danielskatz and unassigned danielskatz May 27, 2020
@whedon
Copy link
Author

whedon commented May 27, 2020

OK, @gorlapraveen is now a reviewer

@danielskatz
Copy link

👋 @garrettj403 - Would you be willing to review this submission for JOSS?

@garrettj403
Copy link

Hi @danielskatz, I can to review this project. 👍

@danielskatz
Copy link

@whedon add @garrettj403 as reviewer

@whedon
Copy link
Author

whedon commented May 28, 2020

OK, @garrettj403 is now a reviewer

@danielskatz
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented May 28, 2020

OK, I've started the review over in #2266.

@whedon whedon closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants