8274506: TestPids.java and TestPidsLimit.java fail with podman run as root

[jerboaa]

Please review this test fix to work around a podman issue[1]. podman expects for the "unlimited" option of --pids-limit to be 0 whereas docker wants -1. See the JBS bug for details. Thoughts?

Testing: hotspot/jdk container tests with docker and podman. Two pids tests used to fail and pass with the patch.

[1] containers/podman#11782

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8274506: TestPids.java and TestPidsLimit.java fail with podman run as root

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)
• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/5750/head:pull/5750
$ git checkout pull/5750

Update a local copy of the PR:
$ git checkout pull/5750
$ git pull https://git.openjdk.java.net/jdk pull/5750/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5750

View PR using the GUI difftool:
$ git pr show -t 5750

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/5750.diff

[jerboaa]

/cc @MBaesken

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jerboaa The label @MBaesken is not a valid label. These labels are valid:

• serviceability
• hotspot
• hotspot-compiler
• ide-support
• kulla
• i18n
• shenandoah
• jdk
• javadoc
• security
• hotspot-runtime
• jmx
• build
• nio
• client
• core-libs
• compiler
• net
• hotspot-gc
• hotspot-jfr

[openjdk]

@jerboaa The following labels will be automatically applied to this pull request:

• core-libs
• hotspot-runtime
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (cb81b8aa)

[MBaesken]

Hello Severin, the test fix looks good to me.

Best regards, Matthias

[openjdk]

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274506: TestPids.java and TestPidsLimit.java fail with podman run as root

Reviewed-by: mbaesken, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 205 new commits pushed to the master branch:

• 79cebe2: 8274050: Unnecessary Vector usage in javax.crypto
• 97b2874: 8274509: Remove stray * and stylistic . from doc comments
• b1b6696: 8274453: (sctp) com/sun/nio/sctp/SctpChannel/CloseDescriptors.java test should be resilient to lsof warnings
• edd9d1c: 8274330: Incorrect encoding of the DistributionPointName object in IssuingDistributionPointExtension
• 980c50d: 8272562: C2: assert(false) failed: Bad graph detected in build_loop_late
• 1dc8fa9: 8274340: [BACKOUT] JDK-8271880: Tighten condition for excluding regions from collecting cards with cross-references
• aaa36cc: 8274242: Implement fast-path for ASCII-compatible CharsetEncoders on x86
• c4d1157: 8271855: [TESTBUG] Wrong weakCompareAndSet assumption in UnsafeIntrinsicsTest
• 756d22c: 8274130: C2: MulNode::Ideal chained transformations may act on wrong nodes
• 5b0c9cc: 8274172: Convert JavadocTester to use NIO
• ... and 195 more: https://git.openjdk.java.net/jdk/compare/31667daa50b2faf82943821ee02071d222e38268...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jerboaa]

Thanks for the review!

[jerboaa]

/integrate

[openjdk]

Going to push as commit 94e31e5.
Since your change was applied there have been 211 commits pushed to the master branch:

• a8210c5: 8274401: C2: GraphKit::load_array_element bypasses Access API
• dfc557c: 8274406: RunThese30M.java failed "assert(!LCA_orig->dominates(pred_block) || early->dominates(pred_block)) failed: early is high enough"
• c0533ef: 8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah
• f8415a9: 8274523: java/lang/management/MemoryMXBean/MemoryTest.java test should handle Shenandoah
• 355356c: 8273435: Remove redundant zero-length check in ClassDesc.of
• 97385d4: 8274405: Suppress warnings on non-serializable non-transient instance fields in javac and javadoc
• 79cebe2: 8274050: Unnecessary Vector usage in javax.crypto
• 97b2874: 8274509: Remove stray * and stylistic . from doc comments
• b1b6696: 8274453: (sctp) com/sun/nio/sctp/SctpChannel/CloseDescriptors.java test should be resilient to lsof warnings
• edd9d1c: 8274330: Incorrect encoding of the DistributionPointName object in IssuingDistributionPointExtension
• ... and 201 more: https://git.openjdk.java.net/jdk/compare/31667daa50b2faf82943821ee02071d222e38268...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa Pushed as commit 94e31e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.