Skip to content

Commit

Permalink
8274406: RunThese30M.java failed "assert(!LCA_orig->dominates(pred_bl…
Browse files Browse the repository at this point in the history
…ock) || early->dominates(pred_block)) failed: early is high enough"

Reviewed-by: kvn, thartmann
  • Loading branch information
chhagedorn committed Sep 30, 2021
1 parent c0533ef commit dfc557c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/hotspot/share/opto/loopopts.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1455,8 +1455,8 @@ void PhaseIdealLoop::try_sink_out_of_loop(Node* n) {
if (n_loop != loop_ctrl && n_loop->is_member(loop_ctrl)) {
// n has a control input inside a loop but get_ctrl() is member of an outer loop. This could happen, for example,
// for Div nodes inside a loop (control input inside loop) without a use except for an UCT (outside the loop).
// Rewire control of n to get_ctrl(n) to move it out of the loop, regardless if its input(s) are later sunk or not.
_igvn.replace_input_of(n, 0, n_ctrl);
// Rewire control of n to right outside of the loop, regardless if its input(s) are later sunk or not.
_igvn.replace_input_of(n, 0, place_outside_loop(n_ctrl, loop_ctrl));
}
}
if (n_loop != _ltree_root && n->outcnt() > 1) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@
* @summary Sinking a data node used as divisor of a DivI node into a zero check UCT loses its pin outside the loop due to
* optimizing the CastII node away, resulting in a div by zero crash (SIGFPE) due to letting the DivI node floating
* back inside the loop.
* @run main/othervm -Xcomp -XX:CompileCommand=compileonly,compiler.loopopts.TestSinkingDivisorLostPin -XX:-TieredCompilation
* @run main/othervm -Xcomp -XX:CompileCommand=compileonly,compiler.loopopts.TestSinkingDivisorLostPin::* -XX:-TieredCompilation
* -XX:+UnlockDiagnosticVMOptions -XX:+StressGCM -XX:StressSeed=4177789702 compiler.loopopts.TestSinkingDivisorLostPin
* @run main/othervm -Xcomp -XX:CompileCommand=compileonly,compiler.loopopts.TestSinkingDivisorLostPin -XX:-TieredCompilation
* @run main/othervm -Xcomp -XX:CompileCommand=compileonly,compiler.loopopts.TestSinkingDivisorLostPin::* -XX:-TieredCompilation
* -XX:+UnlockDiagnosticVMOptions -XX:+StressGCM compiler.loopopts.TestSinkingDivisorLostPin
*/

Expand Down

1 comment on commit dfc557c

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.