Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-serving: Refactor stages #188

Merged
merged 2 commits into from
May 24, 2023
Merged

app-serving: Refactor stages #188

merged 2 commits into from
May 24, 2023

Conversation

robertchoi80
Copy link
Contributor

API 에서 앱서빙 상태 관리 체계를 단순화함에 따라 workflow도 그에 맞게 수정함

@@ -29,7 +29,7 @@ spec:
templates:
- name: exit-handler
steps:
- - name: notify-bluegreen-abort-failure
- - name: notify-abort-failure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yml 에서 이렇게 depth 가 두 번 들어가는건 어떤 의미인가요? (몰라서 질문드립니다 ㅠ)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yml 에서 이렇게 depth 가 두 번 들어가는건 어떤 의미인가요? (몰라서 질문드립니다 ㅠ)

첫번째 - 는 yaml 에서 list 를 의미하는 것이고, 두번째 - 는 실제로 넘어가는 값입니다.
- name: notify-bluegreen-abort-failure 이렇게 - 가 포함되어 값이 넘어갑니다.

Copy link
Member

@Siyeop Siyeop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@seungkyua seungkyua merged commit c36e83d into main May 24, 2023
@seungkyua seungkyua deleted the refactor-stages branch May 24, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants