app-serving: refactor pipeline construction #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pass entire stages regardless of current status - update app status before calling workflow
robertchoi80
changed the title
Siyeop
reviewed
May 24, 2023
Siyeop
reviewed
May 24, 2023
ktkfree
approved these changes
May 24, 2023
|
시엽님 commnet 확인해주시면 merge 하겠습니다. |
& use simpler variable name
|
시엽님 코멘트 내용 모두 수정해서, 바로 머지하겠습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pass entire stages regardless of current status
UI 에서 파이프라인 현황을 보여주기 위해 항상 static하게 전체 stage를 리턴하도록 수정
update app status before calling workflow
기존에 작업 요청 후 workflow에서 최초로 상태를 갱신하던 것을, API 에서 즉시 상태를 갱신하도록 수정
(workflow 생성 delay로 인해 UI에서 화면 갱신 안되던 문제 해결)
openinfradev/tks-flow#188 도 함께 머지되어야 합니다