Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fix: disable redirect logic #81

Merged
merged 1 commit into from
Jun 19, 2023
Merged

minor fix: disable redirect logic #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions internal/delivery/http/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,15 @@ func (h *AuthHandler) Logout(w http.ResponseWriter, r *http.Request) {
http.SetCookie(w, cookie)
}
}

http.Redirect(w, r, redirectUrl, http.StatusFound)
ResponseJSON(w, r, http.StatusFound, nil)

//추후 사용을 위해 주석 처리
//http.Redirect(w, r, redirectUrl, http.StatusFound)
//ResponseJSON(w, r, http.StatusFound, nil)

//추후 사용을 위한 임시 코드
_ = redirectUrl

ResponseJSON(w, r, http.StatusOK, nil)
Comment on lines +125 to +133
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추후 수정해야 하는 코드라면 IDE의 지원을 받을 수 있도록
명시적으로 TODO 또는 FIXME 달아주는 것이 일감 관리를 위해 좋을 것 같습니다.

그렇게 쌓인 TODO가 console에도 4개나 있군요 ㅎㅎ

image

}

func (h *AuthHandler) RefreshToken(w http.ResponseWriter, r *http.Request) {
Expand Down