minor fix: disable redirect logic #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siyeop
reviewed
Jun 16, 2023
Comment on lines
+125
to
+133
|
|
||
| //추후 사용을 위해 주석 처리 | ||
| //http.Redirect(w, r, redirectUrl, http.StatusFound) | ||
| //ResponseJSON(w, r, http.StatusFound, nil) | ||
|
|
||
| //추후 사용을 위한 임시 코드 | ||
| _ = redirectUrl | ||
|
|
||
| ResponseJSON(w, r, http.StatusOK, nil) |
There was a problem hiding this comment.
추후 수정해야 하는 코드라면 IDE의 지원을 받을 수 있도록
명시적으로 TODO 또는 FIXME 달아주는 것이 일감 관리를 위해 좋을 것 같습니다.
그렇게 쌓인 TODO가 console에도 4개나 있군요 ㅎㅎ
ktkfree
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
수정 내용: