Crypto Hardware Formatting and Simplification #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…load/store to instruction name decoder
|
The changes now share logic between AES middle/final rounds and between encrypt and decrypt and with RV64 key schedule instructions, reducing AES area by more than 50%. There is still a bit of optimization to be done. One sbox should be shared between aes64e encryption and aes64ks1i key scheduling. Also much of the sha logic can be shared between instructions, such as the XORs and sign extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of work to format the crypto extension units, and some minor optimization.
Added a few missing test cases.