Convert ZWave binding to use ESH SerialPort classes

[cdjackson]

This modifies the ZWave binding to use the ESH SerialPort classes. This allows serial-over-ip- as per eclipse-archived/smarthome#5560.

I have only tested the binding with a real serial port - not with the IP extension, but that should be handled through the ESH libraries.

Signed-off-by: Chris Jackson [email protected]

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/zwave-binding-updates/51080/658

[cdjackson]

@kaikreuzer is org.eclipse.smarthome.io.transport.serial still available in the new system?

[codeaholics]

Will it have moved to a new (non-ESH) package and bundle name?

[cdjackson]

I don't know - hence why I'm asking ;)

However, I'm assuming, maybe incorrectly, that everything hasn't been refactored as the binding is still using all the original package names - if this has changed it would require a major overhaul of every binding.

[cdjackson]

@kaikreuzer or @openhab/core-maintainers any idea about this?

[5iver]

What is the issue? There are several other bindings using it, but using Import-Package instead of Require-Bundle in the manifest.

[cdjackson]

What is the issue?

As per the failed CI.

[5iver]

I only get a 404 when clicking Details. Or is that the issue? 😄

[cdjackson]

It probably has expired and needs to be rerun.

…

On 26 Mar 2019, at 22:49, Scott Rushworth ***@***.***> wrote: I only get a 404 when clicking Details. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1152 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA_kQ4zkIseZP3jwbPg9mFOjyO9WCYvYks5vaqP6gaJpZM4bwJST>.

[5iver]

19:06:18 Java HotSpot(TM) 64-Bit Server VM warning: Insufficient space for shared memory file:
19:06:18     13077

19:06:50  [ERROR] Internal error: java.lang.RuntimeException: Could not instantiate required component: com.google.inject.ProvisionException: Unable to provision, see the following errors:
19:06:50  [ERROR] 
19:06:50  [ERROR] 1) Error notifying InjectionListener org.eclipse.sisu.plexus.PlexusBeanBinder@42ae9e96 of org.eclipse.tycho.p2.resolver.P2DependencyResolver.
19:06:50  [ERROR] Reason: java.lang.RuntimeException: java.io.IOException: Could not create temp dir /tmp/tycho3657383411294228714equinox
19:06:50  [ERROR] while locating org.eclipse.tycho.p2.resolver.P2DependencyResolver
19:06:50  [ERROR] at ClassRealm[extension>org.eclipse.tycho:tycho-maven-plugin:1.3.0, parent: sun.misc.Launcher$AppClassLoader@7852e922] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
19:06:50  [ERROR] while locating org.eclipse.tycho.core.DependencyResolver annotated with @com.google.inject.name.Named(value=p2)
19:06:50  [ERROR] 
19:06:50  [ERROR] 1 error
19:06:50  [ERROR] role: org.eclipse.tycho.core.DependencyResolver
19:06:50  [ERROR] roleHint: p2
19:06:50  [ERROR] -> [Help 1]
19:06:50  org.apache.maven.InternalErrorException: Internal error: java.lang.RuntimeException: Could not instantiate required component
19:06:50      at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)

It looks like Jenkins is out of space again... openhab/openhab-core#639 (comment).

[cweitkamp]

is org.eclipse.smarthome.io.transport.serial still available in the new system?

Yes, it is. We did not change the namespaces for now. We just moved the code to a different location.

[wborn]

To fix the build just remove this Require-Bundle manifest entry. Instead you should add org.eclipse.smarthome.io.transport.serial to the Import-Package entries.

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/port-not-found-after-system-start-on-openhabianpi/73638/15

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/preparation-for-2-5m2/75738/22

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/zwave-zigbee-rfc2217-remote-serial-port-howto/81633/3

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/solved-zwave-zigbee-rfc2217-remote-serial-port-howto/81633/20

[RafalLukawiecki]

What is the current status of this? Shows as merged but I saw comments on the OpenHAB forum that it has been removed from the binding. Hoping to remote ZWave stick away from OH server, reliability would be important but reading about issues with the socat ZWave solution after connection losses.

[cdjackson]

What is the current status of this? Shows as merged

It is merged.

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/share-z-wave-dongle-over-ip-usb-over-ip-using-ser2net-socat-guide/34895/224