Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[satel] Migrate to bnd build #5303

Merged
merged 1 commit into from
Mar 30, 2019
Merged

[satel] Migrate to bnd build #5303

merged 1 commit into from
Mar 30, 2019

Conversation

Hilbrand
Copy link
Member

@Hilbrand Hilbrand requested review from druciak and a team as code owners March 29, 2019 10:04
@maggu2810 maggu2810 mentioned this pull request Mar 29, 2019
Closed
@Hilbrand Hilbrand added the infrastructure Build system and Karaf related issues and PRs label Mar 29, 2019
cweitkamp
cweitkamp reviewed Mar 29, 2019
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency on gnu.io and conflicts.

@Hilbrand
Copy link
Member Author

Is the dependency of gnu.io a problem? Or is it something we want preferable be removed? I assume it would still work this binding has been moved to the bnd build and it still uses gnu.io?

@cweitkamp
Copy link
Contributor

Is the dependency of gnu.io a problem?

Nevermind. I saw some recent work to suppress its usage (https://github.com/openhab/openhab2-addons/pull/5167 or openhab/org.openhab.binding.zwave#1152) and switch to OHC SerialPort API (eclipse-archived/smarthome#5560). Nothing important for Java 11.

druciak
druciak approved these changes Mar 30, 2019
View reviewed changes
Copy link
Member

@druciak druciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me.

@druciak
Copy link
Member

druciak commented Mar 30, 2019

I saw some recent work to suppress its usage

I will try to switch from gnu.io to the new api once this migration is merged.

@davidgraeff
Copy link
Member

conflicts

@Hilbrand
[satel] Migrate to bnd build
e8344ef 
Signed-off-by: Hilbrand Bouwkamp <[email protected]>
@wborn wborn merged commit 2de5044 into openhab:master Mar 30, 2019
@Hilbrand Hilbrand deleted the satel branch March 30, 2019 21:45
@wborn wborn added this to the 2.5 milestone Apr 14, 2019
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Jun 19, 2019
@Hilbrand @Pshatsillo
[satel] Migrate to bnd build (openhab#5303)
0d6e796 
Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Signed-off-by: Pshatsillo <[email protected]>
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
@Hilbrand @ne0h
[satel] Migrate to bnd build (openhab#5303)
93b0656 
Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Signed-off-by: Maximilian Hess <[email protected]>
@wborn wborn removed this from the 2.5 milestone Dec 8, 2019
@wborn wborn added this to the 2.5 milestone Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitkamp cweitkamp cweitkamp left review comments

@wborn wborn wborn approved these changes

@druciak druciak druciak approved these changes

Assignees
No one assigned
Labels
infrastructure Build system and Karaf related issues and PRs
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.
5 participants
@Hilbrand @cweitkamp @druciak @davidgraeff @wborn