Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thing editing improvements #823

Merged
merged 2 commits into from
Jan 18, 2021
Merged

Thing editing improvements #823

merged 2 commits into from
Jan 18, 2021

Conversation

ghys
Copy link
Member

@ghys ghys commented Jan 18, 2021

Don't save thing when coming back from the Code tab if it hasn't changed - fixes #618.
Disable editing controls if thing is not editable - fixes #570.
Disable editing of config parameters with readOnly enabled - fixes #756.

Signed-off-by: Yannick Schaus [email protected]

@ghys ghys requested a review from a team as a code owner January 18, 2021 16:00
Fixes openhab#618.

Disable editing of config parameters with readOnly enabled.
Fixes openhab#756.

Signed-off-by: Yannick Schaus <[email protected]>
@ghys ghys changed the title Don't save thing when coming back from the Code tab if it hasn't changed Thing editing improvements Jan 18, 2021
@ghys ghys merged commit 0a29ec6 into openhab:master Jan 18, 2021
ghys added a commit that referenced this pull request Jan 18, 2021
Don't save thing when coming back from the Code tab if it hasn't changed - fixes #618.
Disable editing controls if thing is not editable - fixes #570.
Disable editing of config parameters with readOnly enabled - fixes #756.

Signed-off-by: Yannick Schaus <[email protected]>
@ghys ghys added bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch labels Jan 18, 2021
@ghys ghys added this to the 3.1 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
1 participant