Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read-only configuration parameters are editable #756

Closed
cweitkamp opened this issue Jan 4, 2021 · 0 comments · Fixed by #823
Closed

Read-only configuration parameters are editable #756

cweitkamp opened this issue Jan 4, 2021 · 0 comments · Fixed by #823
Labels
bug Something isn't working main ui Main UI

Comments

@cweitkamp
Copy link
Contributor

A configuration parameter flagged as read-only can be edited in the UI:

grafik

grafik

grafik
@cweitkamp cweitkamp added bug Something isn't working main ui Main UI labels Jan 4, 2021
@ghys ghys changed the title [Main UI] Read-only configuration parameters are editable Read-only configuration parameters are editable Jan 14, 2021
ghys added a commit to ghys/openhab-webui that referenced this issue Jan 18, 2021
@ghys
Disable editing controls if thing is not editable
c33d011 
Fixes openhab#618.

Disable editing of config parameters with readOnly enabled.
Fixes openhab#756.

Signed-off-by: Yannick Schaus <[email protected]>
@ghys ghys mentioned this issue Jan 18, 2021
Merged
@ghys ghys closed this as completed in #823 Jan 18, 2021
ghys added a commit that referenced this issue Jan 18, 2021
@ghys
Thing editing improvements (#823)
0a29ec6 
Don't save thing when coming back from the Code tab if it hasn't changed - fixes #618.
Disable editing controls if thing is not editable - fixes #570.
Disable editing of config parameters with readOnly enabled - fixes #756.

Signed-off-by: Yannick Schaus <[email protected]>
ghys added a commit that referenced this issue Jan 18, 2021
@ghys
Thing editing improvements (#823)
7452d7d 
Don't save thing when coming back from the Code tab if it hasn't changed - fixes #618.
Disable editing controls if thing is not editable - fixes #570.
Disable editing of config parameters with readOnly enabled - fixes #756.

Signed-off-by: Yannick Schaus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Thing editing improvements ghys/openhab-webui
1 participant
@cweitkamp