Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to UIDs if things have no label during sorting. #769

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

ghys
Copy link
Member

@ghys ghys commented Jan 8, 2021

Fixes #762.
(but there is probably also an issue in the core
that strips the labels sometimes).

Signed-off-by: Yannick Schaus [email protected]

Fixes openhab#762.
(but there is probably also an issue in the core
that strips the labels sometimes).

Signed-off-by: Yannick Schaus <[email protected]>
@ghys ghys requested a review from a team as a code owner January 8, 2021 14:20
@ghys ghys merged commit e510e6f into openhab:master Jan 8, 2021
@ghys ghys deleted the ghys/issue762 branch January 8, 2021 15:49
crnjan added a commit to crnjan/openhab-webui that referenced this pull request Jan 9, 2021
* master:
  Inbox: Fix error when deleting, add ability to set custom ID (openhab#775)
  Show correct alexa metadata categories for group items (openhab#767)
  Don't show edit/save buttons in model if item is not editable (openhab#774)
  Only show list indexes on mobile devices (openhab#773)
  Consider alarms part of equipment in location glance badges (openhab#772)
  Consider blinds open when state is ON or 0 in blinds glance (openhab#771)
  Fix measurement badges display condition (openhab#770)
  Fallback to UIDs if things have no label during sorting (openhab#769)
  Fix personal widgets ordering (openhab#768)
@pfink
Copy link
Contributor

pfink commented Jan 10, 2021

@openhab/webui-maintainers I'd suggest to add the patch label here.

@ghys ghys added the bug Something isn't working label Jan 11, 2021
@ghys ghys added this to the 3.1 milestone Jan 11, 2021
ghys added a commit to ghys/openhab-webui that referenced this pull request Jan 11, 2021
Fixes openhab#762.
(but there is probably also an issue in the core
that strips the labels sometimes).

Signed-off-by: Yannick Schaus <[email protected]>
@ghys ghys added patch A PR that has been cherry-picked to a patch release branch main ui Main UI labels Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Things in the Things view not getting loaded
2 participants